CM-62381-add-session-start-hook#434
Merged
RoniCycode merged 12 commits intomainfrom Apr 20, 2026
Merged
Conversation
Collaborator
RoniCycode
commented
Apr 9, 2026
RoniCycode
commented
- Change "ensure-auth" to "session-start" which includes conversation creation and MCP usage checks (once per session)
RoniCycode
requested review from
elsapet,
gotbadger and
mateusz-sterczewski
as code owners
Ilanlido
reviewed
Apr 9, 2026
Ilanlido
reviewed
Apr 13, 2026
Ilanlido
reviewed
Apr 14, 2026
Ilanlido
reviewed
Apr 14, 2026
elsapet
reviewed
Apr 15, 2026
Collaborator
elsapet
left a comment
elsapet
left a comment
There was a problem hiding this comment.
Some comments for your consideration but no major blockers IMO 🙏
Ilanlido
reviewed
Apr 19, 2026
elsapet
approved these changes
Apr 20, 2026
MaorDavidzon
added a commit
that referenced
this pull request
Apr 23, 2026
Post-merge fixes after #434 (session-start refactor) landed on main: - consts.py: Codex SessionStart now calls CYCODE_SESSION_START_COMMAND with --ide codex, matching the Cursor/Claude-code pattern (the old CYCODE_ENSURE_AUTH_COMMAND constant was removed). - session_start_command.py: add Codex branch to _build_session_payload so session_start works for the Codex IDE. - handlers.py: drop ai_client.create_conversation() call from handle_before_command_exec; conversation creation now happens in the session-start command, matching the other three handlers. - test_hooks_manager.py: update Codex SessionStart test to assert on CYCODE_SESSION_START_COMMAND + --ide codex. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.