Demo open root url again#152
Merged
Merged
Conversation
The nginx image now sets absolute_redirect off, so its '/' -> /creator/home redirect is relative and keeps whatever host port the client connected on. The creator demo can open the bare root URL rather than /creator/home; the browser is no longer sent to an unpublished port. Also update this repo's docs/demo-nginx-port-redirect-bug.md to match. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The '/' -> /creator/home rewrite now emits a relative 302 rather than an absolute 301, so the browser keeps the client's port and the entry-point redirect is not cached persistently. Update the test to match: assert a 302, and a Location of exactly /creator/home (an exact match, not endswith, so the port-stripping absolute form would fail the test). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.