Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces ACTUS event emission (as ARC-28 events) from payment-agent methods, plus documentation and a new test intended to exercise event logs end-to-end.
Changes:
- Add
EventARC-4 struct schema and ACTUS event type constants (PR/IP), and emit events frompay_couponandpay_principal. - Add a Fixed Coupon Bond test helper to extract/decode event logs and a new test to run through coupon + principal payments.
- Update docs and CI workflow to include/validate ACTUS events behavior.
Reviewed changes
Copilot reviewed 15 out of 25 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
modules/payment_agent/principal.py |
Emit PR event during principal payment. |
modules/payment_agent/coupon.py |
Emit IP event during coupon payment. |
smart_contracts/events.py |
Define the ARC-4 Event struct used for ARC-28 emission. |
smart_contracts/enums.py |
Add ACTUS event type constants (EVT_TYPE_PR, EVT_TYPE_IP). |
tests/utils.py |
Add utilities to extract and decode emitted event logs. |
tests/fixed_coupon_bond/test_actus_events.py |
Add a scenario test intended to exercise event emission for a fixed coupon bond. |
docs/interfaces/payment-agent/pay-coupon.md |
Document emitted IP event for pay_coupon. |
docs/interfaces/payment-agent/pay-principal.md |
Document emitted PR event for pay_principal. |
docs/events/events.md |
Add event schema documentation and supported event types list. |
docs/SUMMARY.md |
Link the new Events documentation page in the docs summary. |
pyproject.toml |
Relax Ruff line-length enforcement across tests/** via E501 ignore. |
.github/workflows/d-asa-ci.yaml |
Add a dedicated CI job to run the ACTUS events test. |
modules/core_financial/coupon.py |
Import formatting only. |
smart_contracts/artifacts/*/*.approval.teal |
Regenerated TEAL artifacts reflecting event emission changes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.