feat: add holding address to payment authorization#88
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fb3ea84500
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Pull request overview
This PR expands payment authorization to allow the holding_address itself to initiate authorized payments (in addition to op_daemon and the configured payment_address), and updates compiled TEAL artifacts accordingly.
Changes:
- Extend
assert_payment_authorizationto authorize whenTxn.sender == holding_address. - Regenerate TEAL artifacts to reflect the new authorization logic.
- Adjust test helper repository path resolution and improve scratch directory cleanup.
Reviewed changes
Copilot reviewed 5 out of 14 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/shared/test_mixin_composition_guards.py | Updates repo root resolution and adds scratch directory cleanup after validation. |
| modules/payment_agent/common.py | Allows holding_address as an authorized caller for payment operations. |
| smart_contracts/artifacts/zero_coupon_bond/ZeroCouponBond.approval.teal | Regenerated TEAL reflecting new authorization path. |
| smart_contracts/artifacts/perpetual_bond/PerpetualBond.approval.teal | Regenerated TEAL reflecting new authorization path. |
| smart_contracts/artifacts/fixed_coupon_bond/FixedCouponBond.approval.teal | Regenerated TEAL reflecting new authorization path. |
| smart_contracts/artifacts/fixed_coupon_bond/FixedCouponBond.approval.puya.map | Regenerated source map to match the updated TEAL. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.