Freeqpairs, fixing memry leak for trimmed/replaced query pairs - #437
Merged
Merged
Conversation
arpitguptagithub
force-pushed
the
fix/freeqpairs-memory-leak
branch
from
April 11, 2026 09:11
8fe3e97 to
62d105e
Compare
When trim() or replace() marks a query pair as deleted, they set
len = 0 but allocate a new str via xstrdup(""). Since freeqpairs()
only freed entries where len != 0, those strdup'd empty strings were
leaked.
Fix by checking str (non-NULL) instead of len (non-zero) as the guard
for freeing.
Add a test that trims a middle query key to exercise this code path.
arpitguptagithub
force-pushed
the
fix/freeqpairs-memory-leak
branch
from
April 11, 2026 09:17
62d105e to
7acd826
Compare
bagder
approved these changes
Apr 12, 2026
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When trim() or replace() marks a query pair as deleted, they set len = 0 but allocate a new str via xstrdup(""). Since freeqpairs() only freed entries where len != 0, those strdup'd empty strings were leaked.
The fix is quite easy just check str (non-NULL) instead of len (non-zero) as the guard for freeing.
Add a test that trims a middle query key to exercise this code path.