Fix wrong isRemote false caused by the incorrect promise schedule case.#61
Open
ulion wants to merge 2 commits intocudr:masterfrom
Open
Fix wrong isRemote false caused by the incorrect promise schedule case.#61ulion wants to merge 2 commits intocudr:masterfrom
ulion wants to merge 2 commits intocudr:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The isRemote false promise should only be scheduled when any apply (slate schedule onChange in first apply) really happened.
Else, currently, is we got two remote applyOperation calls one by one, the first empty slate op one will schedule isRemote false, then the 2nd applyOperation will schedule onChange, and another isRemote false. which finally will cause the onChange runs with e.isRemote === false, and which will cause the remote caused slate ops be applied as local slate op again, and it will cause error.
This PR make sure only schedule isRemote = false when there is any onChange is scheduled, then it runs just after it to clear the isRemote flag.