-
-
Notifications
You must be signed in to change notification settings - Fork 19
Enhance better-gherkin.md with an additional style #170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Added examples of scenarios that are between imperative and declarative
✅ Deploy Preview for cucumber-website-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
mpkorstanje
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Ken, thanks for writing this. But the "why" isn't immediately obvious to me. Why would we recommend an in-between style? And how does this help users make their Gherkin better?
|
|
||
| ## In-Between Imperative and Declarative | ||
|
|
||
| There is a style between these two. It demonstrates the logical flow, without the details of the user interface. The data can be used to automate the test the core implementation, as well as used to either manually or automatically test the user interface. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unclear reference. What are "these two"? Something in between "Describing behavior" and "Consider a more declarative style" (the page headings). Or something in between declarative and imperative?
If the latter then this should be under a h3, not a h2.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also hope that we don't recommend manual non-exploratory testing 😉 .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the comments. The name was not as descriptive and the reasoning was short. What about something that looked like this.
gherkin better - addition.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not suggesting manual non-exploratory testing. The data could be used as the starting point for exploratory testing.
In some cases, automating UI tests is deferred to later in the development process. The data could be used as for a manual test of the UI in the interim.
| Scenario: Free subscribers see only the free articles | ||
| Given user is logged in | ||
| | User Name | Password | Subscription | | ||
| | [email protected] | validPassword123 | Free | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are incidental details. Ideally they're kept out of the Gherkin. I wouldn't recommend this to any one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My original scenario was bad. I just copied the data from the first one. Too fast and not enough thought.
There should be a separate scenarios for logging on showing responses for user input variations
Added examples of scenarios that are between imperative and declarative.
As Jerry Weinberg says, "There are at least three solutions to every problem"
🤔 What's changed?
⚡️ What's your motivation?
🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
📋 Checklist:
This text was originally generated from a template, then edited by hand. You can modify the template here.