Stop any commands running after each spec in Aruba's spec suite#1048
Draft
mvz wants to merge 2 commits into
Draft
Stop any commands running after each spec in Aruba's spec suite#1048mvz wants to merge 2 commits into
mvz wants to merge 2 commits into
Conversation
On windows, commands left running prevent clean-up of tmp files used to store stdout and stderr. This change should ensure commands are stopped and tmp files closed before they're garbage-collected.
mvz
marked this pull request as draft
July 12, 2026 12:24
Contributor
Author
|
This does not have the desired effect. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clean up running commands after each spec.
Details
On windows, commands left running prevent clean-up of tmp files used to store stdout and stderr. This change should ensure commands are stopped and tmp files closed before they're garbage-collected.
Motivation and Context
The specs on windows report a lot of warnings about access being denied on tmp files. This should clean that up.
How Has This Been Tested?
I ran one spec locally. This should mainly be tested by checking the logs in CI.
Types of changes
Checklist:
N/A