Skip to content

Conversation

@amjiao
Copy link
Contributor

@amjiao amjiao commented Nov 15, 2025

Overview

HighlightsSearchScreen + HighlightsSubScreen
related components

Changes Made

All components for search screens complete
Updated nav bar so HighlightsScreen is accessible when app is run
Other search screens can be viewed via previews

Test Coverage

Visually matches figma

Next Steps

Code structure/logical flow def isn't perfect rn, will clean that up when I network

Screenshots

Screenshot 2025-11-14 at 11 16 40 PM Screenshot 2025-11-14 at 11 16 50 PM

search bar functionality

score_pr90.webm

@amjiao amjiao marked this pull request as ready for review November 15, 2025 04:23
@amjiao amjiao requested a review from zachseidner1 November 15, 2025 04:24
@amjiao amjiao marked this pull request as draft November 15, 2025 05:17
@zachseidner1 zachseidner1 removed their request for review November 15, 2025 14:36
@amjiao amjiao marked this pull request as ready for review November 19, 2025 03:44
Copy link
Member

@AndrewCheung360 AndrewCheung360 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to preemptively approve, but left some comments about the focus logic and some nits. Great work!

@amjiao amjiao merged commit 08c1378 into main Jan 12, 2026
4 checks passed
@amjiao amjiao deleted the amy-highlights branch January 12, 2026 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants