Skip to content

Implement loading timeouts #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zachseidner1 merged 2 commits into from
Apr 21, 2025
Merged

Implement loading timeouts #76

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4aa22bd
Implement loading timeouts
zachseidner1 Apr 21, 2025
ac4e70e
Remove bad parenthesis
zachseidner1 Apr 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions app/src/main/java/com/cornellappdev/score/model/ScoreRepository.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package com.cornellappdev.score.model

import android.util.Log
import com.apollographql.apollo.ApolloClient
import com.cornellappdev.score.util.isValidSport
import com.cornellappdev.score.util.parseColor
import com.example.score.GameByIdQuery
import com.example.score.GamesQuery
Expand All @@ -10,9 +11,11 @@ import kotlinx.coroutines.flow.MutableStateFlow
import kotlinx.coroutines.flow.asStateFlow
import kotlinx.coroutines.flow.update
import kotlinx.coroutines.launch
import kotlinx.coroutines.withTimeout
import javax.inject.Inject
import javax.inject.Singleton
import com.cornellappdev.score.util.isValidSport

private const val TIMEOUT_TIME_MILLIS = 5000L

/**
* This is a singleton responsible for fetching and caching all data for Score.
Expand Down Expand Up @@ -40,7 +43,10 @@ class ScoreRepository @Inject constructor(
fun fetchGames() = appScope.launch {
_upcomingGamesFlow.value = ApiResponse.Loading
try {
val result = (apolloClient.query(GamesQuery()).execute()).toResult()
val result =
withTimeout(TIMEOUT_TIME_MILLIS) {
apolloClient.query((GamesQuery())).execute().toResult()
}

if (result.isSuccess) {
val games = result.getOrNull()
Expand Down Expand Up @@ -93,7 +99,12 @@ class ScoreRepository @Inject constructor(
fun getGameById(id: String) = appScope.launch {
_currentGameFlow.value = ApiResponse.Loading
try {
val result = (apolloClient.query(GameByIdQuery(id)).execute()).toResult()
val result =
withTimeout(TIMEOUT_TIME_MILLIS) {
apolloClient.query(GameByIdQuery(id)).execute().toResult()
}


result.getOrNull()?.game?.let {
_currentGameFlow.value = ApiResponse.Success(it.toGameDetails())
} ?: _currentGameFlow.update { ApiResponse.Error }
Expand Down