Emil jiang navigate #73
Conversation
… emil_jiang_navigate
zachseidner1
left a comment
zachseidner1
left a comment
There was a problem hiding this comment.
After a bit of research I found out that this should definitely be possible to do this with type safety. See this Stack Overflow, we need to use the typeMap parameter of composable in our root navigator. If you have time today, I'd love for you to take a crack at it. Otherwise we can leave it like this and create a GitHub issue, because it's not that bad.
Regardless of what you decide to do, you need to fix the icon for navigating to the scoring summary.
| Icon( | ||
| painter = painterResource(id = R.drawable.ic_right_chevron), | ||
| contentDescription = "Back button", | ||
| modifier = Modifier | ||
| .width(24.dp) | ||
| .height(24.dp), | ||
| ) |
There was a problem hiding this comment.
the icon appears really off here?
|
I saw that stackoverflow, but I did not know how to add the typeMap as that requires some sort of external library, and I think I need to create a ListNavType which I do not really know how to do. |
# Conflicts: # app/src/main/java/com/cornellappdev/score/components/ScoreBox.kt
I added navigation in the game details screen. I am not sure if this is the best way to do it, but it was the only way I could think of after trying many things. To test, the best way I found was to go into past scores and go from there as many of the future games do not have scoring summaries. #46