Skip to content

Conversation

@amjiao
Copy link
Contributor

@amjiao amjiao commented Apr 14, 2025

Overview

Address issue #44

Changes Made

Rounded corners and included border

Test Coverage

Checked visually, matches Figma

@amjiao amjiao requested a review from zachseidner1 April 14, 2025 20:09
@zachseidner1 zachseidner1 linked an issue Apr 14, 2025 that may be closed by this pull request
Copy link
Collaborator

@zachseidner1 zachseidner1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this Amy. I think there are some code quality improvements you could make for the UI. Additionally, the main thing this was supposed to fix is how long scores appear, which your change does not address. See how the preview I added displays differently than the Figma? I think you'll need a minimum width on the text, and also account for text overflow and use ellipses

@amjiao
Copy link
Contributor Author

amjiao commented Apr 22, 2025

  • Edited GameDetailsScreen lines because the ScoreBox covers the case where the score breakdown is empty (with the placeholder hyphens) and ScoreBox should always display if current time is past the game start time.
  • Didn't implement the team icon instead of team name change because I think I'd have to mess around with data classes and I should prob focus on finishing other issues first

@amjiao amjiao requested a review from zachseidner1 April 22, 2025 01:00
Copy link
Collaborator

@zachseidner1 zachseidner1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just barely ready for MVP but there are still some issues that I'd like you to resolve.
image
We're missing the drop shadow around the score box. The border gets cut off at the corner. Also, the school names should have a min width of 60 as specified by the design. Also, the numbers for the periods are not center aligned with their scores.

Just merge it for now, and I'll create a GitHub issue so we can follow up later.

@amjiao amjiao merged commit deb9ff6 into main Apr 22, 2025
1 check passed
@amjiao amjiao deleted the Amy/fix-scoring-box-summary branch April 22, 2025 02:27
@amjiao amjiao self-assigned this Sep 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix scoring box summary UI

3 participants