Address sport filter (issue #40) #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachseidner1
approved these changes
Apr 14, 2025
Collaborator
zachseidner1
left a comment
zachseidner1
left a comment
There was a problem hiding this comment.
Nice job! There's one note for code readability you can address, and then after that feel free to merge.
Comment on lines
171
to
175
| null -> Sport.entries | ||
| GenderDivision.MALE -> Sport.entries.filter { it.gender == GenderDivision.MALE || it.gender == GenderDivision.ALL } | ||
| GenderDivision.FEMALE -> Sport.entries.filter { it.gender == GenderDivision.FEMALE || it.gender == GenderDivision.ALL } | ||
| GenderDivision.ALL -> Sport.entries | ||
| } |
Collaborator
There was a problem hiding this comment.
you can combine cases with the same result in a when statement as such:
GenderDivision.MALE -> Sport.entries.filter { it.gender == GenderDivision.MALE || it.gender == GenderDivision.ALL }
GenderDivision.FEMALE -> Sport.entries.filter { it.gender == GenderDivision.FEMALE || it.gender == GenderDivision.ALL }
GenderDivision.ALL,
null -> Sport.entries
amjiao
added a commit
that referenced
this pull request
Apr 15, 2025
amjiao
added a commit
that referenced
this pull request
Apr 22, 2025
* Empty state + UI fixes * Address UI issues (#51) * Add missing border * Bump material version in preparation for pull to refresh * Fix border on home and past, fix carousel # Conflicts: # app/src/main/java/com/cornellappdev/score/screen/HomeScreen.kt # app/src/main/java/com/cornellappdev/score/screen/PastGamesScreen.kt * Address sport filter (issue #40) (#47) * Fix sport filter * Small readability fix * Empty state + UI fixes * Fix merging * small fix * PR Fixes * Small fixes * PR fixes --------- Co-authored-by: Zachary Seidner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Changes Made
Updated Sport enum class to include a gender property so that getSportSelectionList can return a filtered list given a specified gender.
Test Coverage
Ran the emulator, filtering behavior appears to be working correctly
Related PRs or Issues (delete if not applicable)
issue #40