Change View Model Scoping #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
This reverts commit 15ad1d7.
# Conflicts: # app/src/main/java/com/cornellappdev/score/nav/root/RootNavigation.kt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Before every time we changed destinations via navigation, the page would refresh. This is because the ViewModels were scoped to their Composables so they would get deconstructed and reinitialized whenever we switched between tabs. This change makes it so the view models are now scoped to the root composable of the app instead of their screen composables. ViewModels are no longer reinitialized when switching between tabs from the bottom bar, which corrects the ViewModel refresh issue.
Fixes #35
Changes made
Demo
Screens don't refresh:
Screen_recording_20250326_213404.webm