-
Notifications
You must be signed in to change notification settings - Fork 0
Implement navigation and past games screen UI/ViewModel/majority of networking #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
zachseidner1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Helen, this is a really impressive first draft! Everything looks nice overall, and I am hoping that after resolving the merge conflicts and taking a look at my comments you should be good. Please try to do this as soon as you reasonably can in case I end up having more comments, since we want to make sure this gets in in time. You did some real clever stuff in this PR that I even learned something lol.
app/src/main/java/com/cornellappdev/score/components/FeaturedGameCard.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/cornellappdev/score/components/FeaturedGameCard.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/cornellappdev/score/components/PastGameCard.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/cornellappdev/score/components/PastGameCard.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/cornellappdev/score/components/GamesCarousel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/cornellappdev/score/screen/PastGamesScreen.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/cornellappdev/score/screen/PastGamesScreen.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/cornellappdev/score/viewmodel/PastGamesViewModel.kt
Show resolved
Hide resolved
zachseidner1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really great work, we're so close. I think if you just clean up the past games card a little bit, you should be good!
app/src/main/java/com/cornellappdev/score/viewmodel/PastGamesViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/cornellappdev/score/components/PastGameCard.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/cornellappdev/score/components/PastGameCard.kt
Outdated
Show resolved
Hide resolved
zachseidner1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for resolving the second round of comments! Ship it 🚀 🔥
Overview
Implemented Past Games (aka Scores) screen, with the associated ViewModel and most of networking. Also implemented bottom bar and navigation between game cards (on both Home and Past Games Screen) to a dummy game details screen.
Changes Made
UpcomingGameCardtoFeaturedGameCard,SportCardtoGameCard,UpcomingGamesCarouseltoGamesCarousel)PastGameCardandPastGamesScreen(PastGameCards are properly spaced on this screen)PastGamesViewModelGameCard/PastGameCardto a dummyGameDetailsPage-- will currently navigate back to the correct page when clicking the back arrow on theGameDetailsScreenPastGamesScreenGameCardso long event/university names don't push the sport/gender icon off the cardAdditional Notes
resultstring, which is oftentimes in the format Result, CornellScore-OpponentScore (e.g. "W, 2-1"). Not all of the strings are in this format (e.g. 4th of 6, 1498 points for women's Swimming and Diving), but in this case, thecornellScoreandotherScoreparameters of the game and associated card should be null, and as of right now, null-scored games are filtered out.