HomeViewModel/ScoreRepositoryRefactor #27
Conversation
Commented them out since they currently aren't being used
app/src/main/java/com/cornellappdev/score/model/ScoreRepository.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/cornellappdev/score/model/ScoreRepository.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/cornellappdev/score/model/ScoreRepository.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/cornellappdev/score/model/ScoreRepository.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/cornellappdev/score/viewmodel/HomeViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/cornellappdev/score/viewmodel/HomeViewModel.kt
Outdated
Show resolved
Hide resolved
zachseidner1
left a comment
zachseidner1
left a comment
There was a problem hiding this comment.
Oops my old review told you to refactor all the filters to use flows, even though that's the way it should be done, I realized it's probably not worth it for us right now. I want you to not have to go through an entire refactor so let's just leave a TODO comment for now. The current solution works and is more concise.
…ndroid into Amy/games-model
|
I think the formatColor function needs to be kept since it parses the String into a valid Color input and applies the appropriate alpha, so I feel like it's a little long to put in one line and I also feel like it needs documentation? I just moved the function into the ScoreRepository which seems a bit off so let me know if you see a better way to approach this. |
zachseidner1
left a comment
zachseidner1
left a comment
There was a problem hiding this comment.
Nice job with this refactor! We're almost there. I appreciate your work 🙏
Overview
Addressed issue #21
Screenshots (delete if not applicable)
UI looks the same