Skip to content

Conversation

@mlonn
Copy link

@mlonn mlonn commented Jul 21, 2017

Makes it possible to deploy app without forking, also requiers user to enter nessecary environment variables.

@lindskogen
Copy link
Contributor

Greatly improves usability! Really well done @mlonn!

I would request that you decide on what language the descriptions for environment variables are in, English or Swedish.

Technically, we cannot merge this until the changes are approved on the next "sektionsmöte", but I will try to make this happen!

@bark bark requested review from bark and lindskogen July 21, 2017 08:29
@lindskogen lindskogen requested review from Dr-Horv and NeonNeon July 21, 2017 08:43
"name": "VoteIT",
"description": "A voting system",
"repository": "https://github.com/cthit/VoteIT",
"logo": "http://imgur.com/3Xwg8XF.png",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps shouldn't refer to logo on imgur? Better to refer to one on GitHub or Chalmers.it

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is this logo used?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants