Conversation
BSchilperoort
approved these changes
Dec 2, 2025
BSchilperoort
left a comment
BSchilperoort
left a comment
There was a problem hiding this comment.
Looks good!
I guess this means that we'll have to make some changes to grpc4bmi and RemoteBMI though, to shift to these definitions instead of eWaterCycle/bmi-r. Hopefully we get the opportunity to work on that again soon.
Member
Author
|
Thanks, @BSchilperoort! If you're OK with it, I would like to help with updates to grpc4bmi and RemoteBMI. |
That would be great. I think the main changes are actually contained to RemoteBMI. I made some issues and a project board here; Move to CSDMS R BMI (view) IMO it would be best to deprecate grpc4bmi's R functionality. We don't use it ourselves anymore and I am not aware of any other users. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR lists Basic Model Interface R mappings and an example in the documentation. The mappings are based on those created by @sverhoeven in eWaterCycle/bmi-r. In writing the current mappings and example, I received help from @sverhoeven and @BSchilperoort.
Because the mappings haven't been field-tested, I chose to list them under the "community contributed" table in the documentation. My hope is that by making this code public, any flaws will be exposed, and we can then return to improve it.
This fixes #17.