Reference variables by number rather than name strings#192
Open
PhilMiller wants to merge 2 commits intobmi-3-developmentfrom
Open
Reference variables by number rather than name strings#192PhilMiller wants to merge 2 commits intobmi-3-developmentfrom
PhilMiller wants to merge 2 commits intobmi-3-developmentfrom
Conversation
Member
Author
|
Rolf suggests this hurts usability and code readability for simpler use cases Bert noted concerns around dynamic or parseable variables names. It could be a time savings, but shifts burdens around Bert noted wrappers on libraries like NetCDF in Matlab to simplify usage while maintaining a low-level efficient API. |
Member
Author
|
Fred: suggests an alternative approach of adding a |
Member
Author
|
Agreement on "can implement a friendly interface on an efficient interface, but can't implement an efficient interface on a cumbersome interface" |
Member
Author
|
Potential to implement desired functions in a "high performance methods" extension |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
String processing is cumbersome to implement and potentially expensive during execution. We already accept identifying grids by number rather than name. Let's shift to identifying variables by number, since their names are going to be passed around much more frequently.