Merged
Conversation
PetruCristian
force-pushed
the
lab-07-x86_64-version
branch
from
9f11354 to
54f6d07
Compare
Author
|
Aside from the lab 7 file, I also modified a file from lab 9 to fix a super linter error, but another one showed up in a different lab. I presume those issues have been fixed on other branches. |
teodutu
requested changes
Aug 5, 2025
teodutu
left a comment
teodutu
left a comment
There was a problem hiding this comment.
Mostly nice work. Apply my feedback then we can merge this
PetruCristian
force-pushed
the
lab-07-x86_64-version
branch
from
54f6d07 to
65f44f2
Compare
teodutu
requested changes
Aug 8, 2025
| ; input values (eax, edx): the 2 numbers to compute the gcd for | ||
| mov eax, 49 | ||
| mov edx, 28 | ||
| ; input values (rax, rdx): the 2 numbers to compute the gcd for |
There was a problem hiding this comment.
Suggested change
| ; input values (rax, rdx): the 2 numbers to compute the gcd for | |
| push rbp | |
| mov rbp, rsp | |
| ; input values (rax, rdx): the 2 numbers to compute the gcd for |
Align the stack
Comment on lines
+8
to
+10
| push rbp | ||
| mov rbp, rsp | ||
|
|
Comment on lines
+15
to
+16
| push rbp | ||
| mov rbp, rsp |
There was a problem hiding this comment.
Ditto: the support code suffers from the same seg fault.
PetruCristian
force-pushed
the
lab-07-x86_64-version
branch
from
65f44f2 to
d5d1551
Compare
teodutu
force-pushed
the
lab-07-x86_64-version
branch
from
d5d1551 to
edcada3
Compare
Reading material was modified to include x86_64 registers and instructions. Solutions, support code and tests were modified to work on x86_64 assembly and use the extended ISA. Signed-off-by: PetruCristian <naniacristian26@gmail.com>
teodutu
force-pushed
the
lab-07-x86_64-version
branch
from
edcada3 to
5a3088e
Compare
teodutu
approved these changes
Aug 22, 2025
teodutu
left a comment
teodutu
left a comment
There was a problem hiding this comment.
There were but a few finishing touches to be made and it was faster for me to do them myself. Nice work @PetruCristian!
labs/lab-07/tasks/stack-addressing/solution/stack-addressing.asm
Outdated
Show resolved
Hide resolved
|
The super-linter error is unrelated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisite Checklist
Description of changes
Reading material for lab 7 was modified to include x96_64 registers and instructions. Solutions, support code and tests were modified to work on x86_64 assembly and use the extended ISA.