Conversation
Observe rejected any external-name that was not a numeric ID, so an observe-only Group could not be declared when only the path was known. GitLab's GET /groups/:id accepts the URL-encoded full path as well, and the client already takes either form. Pass the external-name through unchanged and, when it is not numeric, replace it with the returned ID and report the resource as late-initialized. The path is mutable through renames and transfers, so it only bootstraps the lookup; the immutable ID is tracked afterwards. The pin persists when the management policy includes LateInitialize. Refs crossplane-contrib#318 Signed-off-by: ahauser <andreas.hauser@vector.com>
Apply the same lookup as for groups: a non-numeric external-name is sent to GET /projects/:id as the full path, replaced by the returned ID and reported as late-initialized so the immutable ID is tracked afterwards. Refs crossplane-contrib#318 Signed-off-by: ahauser <andreas.hauser@vector.com>
Observe-only Group and Project examples show the path form together with the LateInitialize policy that persists the resolved ID. Fixes crossplane-contrib#318 Signed-off-by: ahauser <andreas.hauser@vector.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
I want to declare observe-only
GroupandProjectresources for cases where only the full path is known, not the numeric ID.This implements the approach @markussiebert outlined in #318.
crossplane.io/external-nameis still the ID.On the open question in #318: the first reconcile always persists the ID, because the finalizer is added after
Observewith a full object update.LateInitializeis only needed to persist a later change of the annotation to a path. Without it the path is resolved on every reconcile, which still works.Fixes #318
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
make runagainst GitLab 19.3.2-ee using a scratch group and project:Groupand forProject, with[Observe, LateInitialize]and[Observe]Synced=False, nothing created