docs: clarify the package-health check in the test-examples skill - #78
Merged
jbw976 merged 1 commit intoJun 14, 2026
Merged
Conversation
The Phase 1 setup check didn't say packages take a few minutes to pull or how to wait for them, which invited ad-hoc awk-based poll loops that never converge because `kubectl get pkg` prints separate Function and Provider tables with their own header rows. Spell out that the check needs polling, and reuse the `grep True/False` pattern already documented in Phase 3.2. Signed-off-by: Jared Watts <jbw976@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
The Phase 1 setup check in the
test-examplesskill told the runner to verify packages with a one-shotkubectl get pkgshowingINSTALLED=True/HEALTHY=True, but never said packages take a few minutes to pull or how to wait for them.That gap invited ad-hoc awk-based poll loops that never converge:
kubectl get pkgprints separate Function and Provider tables, each with its own header row, so column counting against a single header never matches.This clarifies that the check needs polling, and routes to the same
grep True/Falseapproach the skill already documents for trace parsing in Phase 3.2. Docs-only change to the skill under.claude/; no behavior change to the examples.I have:
Added or updated unit tests for my change.Docs-only change to a skill file; no unit tests apply.