Open
Conversation
Скопипастил предъидущий проект Почти сверстал
Сел рефакторить + писать доки + удоволетворять jsLint
Прошел более мение jsLint Написал JS Doc
Task/Scripts/BaseEvent.js
Outdated
Member
There was a problem hiding this comment.
Странный какой-то отступ у JSDoc
/**
* @param {Date} formDate
Author
There was a problem hiding this comment.
Исправил на стандартный
Member
|
💯 Все хорошо. Учтем твой фидбэк расскажем про шаблонизаторы на предстоящей лекции. |
Author
|
Закомитил все исправления ^_^, и наконец то познал силу IIFE |
Member
|
Отлично, все супер. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Вроде сделала все, что требовалось, но мне кажется я ужасно пользуюсь DOM.
Мне кажется на лекции про DOM сильно не хватало примеров, как нужно писать и как не нужно писать.
Для меня это задание было очень сложным из - за двух причин:
Но все равно было интересно