Skip to content

User system refacto#422

Open
mRoca wants to merge 3 commits intomasterfrom
user-system-refacto
Open

User system refacto#422
mRoca wants to merge 3 commits intomasterfrom
user-system-refacto

Conversation

@mRoca
Copy link
Contributor

@mRoca mRoca commented Nov 4, 2020

No description provided.

@mRoca mRoca force-pushed the user-system-refacto branch 4 times, most recently from 7eb7206 to 9023323 Compare November 7, 2020 19:54
@mRoca mRoca changed the title WIP: User system refacto User system refacto Nov 7, 2020
@mRoca
Copy link
Contributor Author

mRoca commented Nov 7, 2020

@vincentchalamon je viens de terminer la partie des templates / email & tests, j'ai l'impression que tout devrait être bon, t'as fait un super taf ! T'aurais le temps de te replonger dedans histoire de voir si j'ai pas oublié un truc ?

This was linked to issues Nov 8, 2020
Add organization planning display tests #284
Open
Add functional test for all routes #320
Open
User system refacto #338
Open
Asset creation from parent organization buggy #360
Open
@vincentchalamon
Copy link
Contributor

vincentchalamon commented Nov 8, 2020

@mRoca Ça me semble bien pour cette PR, sauf la CI qui gueule (les tests à corriger je pense).

Il faudrait également mettre à jour le fichier .github/workflows/ci.yml pour corriger une dépréciation (qui est en fait une faille de sécurité).

@vincentchalamon vincentchalamon self-requested a review November 8, 2020 17:41
@mRoca
Copy link
Contributor Author

mRoca commented Nov 9, 2020

J'ai vu pour les tests: c'est à cause de mes dernières modifs pour les emails. Je fix tout ça ce soir

@mRoca mRoca force-pushed the user-system-refacto branch 4 times, most recently from 781791d to c96c81f Compare November 13, 2020 11:45
@mRoca
Copy link
Contributor Author

mRoca commented Nov 13, 2020

@vincentchalamon t'en penses quoi ?

vincentchalamon
vincentchalamon suggested changes Nov 13, 2020
View reviewed changes
Copy link
Contributor

@vincentchalamon vincentchalamon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pense à mettre à jour le fichier .github/workflows/ci.yaml pour corriger la faille de sécurité (cf. précédent commentaire)

Sinon c'est niquel ! Beau boulot !

@mRoca mRoca force-pushed the user-system-refacto branch from c96c81f to e5acd49 Compare November 13, 2020 12:32
vincentchalamon and others added 2 commits November 13, 2020 13:48
@vincentchalamon @mRoca
Prepare Behat scenarios for User system refacto (#339)
5d8632d
@vincentchalamon @mRoca
Refacto User & Organization (#405)
64051aa 
* Prepare Behat scenarios for User system refacto (#339)

* Refacto User login

* Add reset password

* Add Organization promote/revoke User

* Add ROLE_SUPER_ADMIN

* Add User impersonification for super-admin only

* Remove useless ROLE_VOLUNTEER

* wip

* Fix PHP-CS

Co-authored-by: Michel Roca <mroca.dh@gmail.com>
@mRoca mRoca force-pushed the user-system-refacto branch from e5acd49 to f90c90d Compare November 13, 2020 12:49
@mRoca mRoca force-pushed the user-system-refacto branch from f90c90d to b241870 Compare November 26, 2020 16:02
@mRoca
Copy link
Contributor Author

mRoca commented Nov 30, 2020

TODO before merging:

  • Définir le premier utilisateur inscrit comme SUPER_ADMIN
  • Ajouter la doc d'installation

@mRoca mRoca force-pushed the user-system-refacto branch 3 times, most recently from 943bf93 to 4ace493 Compare December 21, 2020 10:00
@mRoca mRoca force-pushed the user-system-refacto branch from 4ace493 to dc84ca4 Compare December 21, 2020 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@vincentchalamon vincentchalamon vincentchalamon approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Asset creation from parent organization buggy User system refacto Add functional test for all routes Add organization planning display tests

2 participants

@mRoca @vincentchalamon