Use new shim.VMExists to verify VM existence before executing #337
+81
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit migrates VM existence checks from LoadMachineByName to shim.VMExists, which verifies VM existence on both disk and hypervisor. This ensures that VMs deleted externally (e.g. through Hyper-V Manager) are correctly identified as non-existent, even if configuration files remain on disk. Signed-off-by: lstocchi <lstocchi@redhat.com>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This needs cfergeau/podman#43 to be merged first
This PR migrates VM existence checks from LoadMachineByName to shim.VMExists, which verifies VM existence on both disk and hypervisor. This ensures that VMs deleted externally (e.g. through Hyper-V Manager) are correctly identified as non-existent, even if configuration files remain on disk.
It resolves #265