Testing: Use native Testcontainers adapter#502
Draft
amotl wants to merge 3 commits into
Draft
Conversation
amotl
commented
Jun 18, 2026
| 'crate[test]>=1.0.0.dev2', | ||
| 'cratedb-toolkit[testing]', | ||
| 'sqlalchemy-cratedb', | ||
| 'testcontainers[cratedb] @ git+https://github.com/testcontainers/testcontainers-python.git@main', |
Contributor
Author
There was a problem hiding this comment.
As soon as there will be a GA release, we can switch over.
Suggested change
| 'testcontainers[cratedb] @ git+https://github.com/testcontainers/testcontainers-python.git@main', | |
| 'testcontainers[cratedb]>=4.15', |
There was a problem hiding this comment.
should we proceed the same way wherever else we have python testcontainers, I wonder, or wait for GA?
Contributor
Author
There was a problem hiding this comment.
I think version 4.15 will be around the corner, possibly becoming GA next week already, before the summer heat waves will begin? In this spirit, I think it will be good to wait for an official release before merging this patch.
-- https://pypi.org/project/testcontainers/#history
/cc @alexanderankin
amotl
force-pushed
the
testcontainers-native
branch
from
9ef08e4 to
4bfa4b2
Compare
amotl
force-pushed
the
testcontainers-native
branch
from
f073808 to
8768c26
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About
Thanks to @surister and @florinutz, the upstream testcontainers package will include an adapter for CrateDB. With this patch, the test suite will start using it.
References