Skip to content

Conversation

@eisenwave
Copy link
Member

This follows the precedent of https://eel.is/c++draft/simd.complex.access#3.2, which says

same_as<...> is modeled

We could probably also use is_same_v here instead, but that would create a local inconsistency with [simd.complex.access], and the three uses here are clearly wrong.

@eisenwave eisenwave added the P2-Bug Presentational errors and omissions label Nov 16, 2025
@hewillk
Copy link
Contributor

hewillk commented Nov 16, 2025

There are nothing wrong with "If same_as<A, B> is true", we use a lots in <ranges>, see https://eel.is/c++draft/ranges#range.iota.view-10.1
The statement "If same_as<A, B> is model" is unnecessary because we are only checking the constraint here, and we are not asking about its semantics, which is much simpler.
I honestly don't see any improvement from is_same_v, except for being more verbose.

Copy link
Member

@jensmaurer jensmaurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding \libconcept is fine and expected.

Switching to "is modeled" is a potentially normative change (causing UB if the semantic implications of a concept are not met), whereas using the concept-id as a boolean expression is totally fine and only checks the "satisfied" part.

Please limit the editorial change to adding \libconcept.

@jensmaurer jensmaurer added the changes requested Changes to the wording or approach have been requested and not yet applied. label Nov 16, 2025
@eisenwave eisenwave changed the title [simd] Add missing \libconcept and say "is modeled" for uses of same_as [simd] Add missing \libconcept to uses of same_as Nov 16, 2025
@eisenwave eisenwave removed the changes requested Changes to the wording or approach have been requested and not yet applied. label Nov 16, 2025
@eisenwave eisenwave requested a review from jensmaurer November 16, 2025 18:23
@jensmaurer jensmaurer merged commit a82da99 into cplusplus:main Nov 16, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P2-Bug Presentational errors and omissions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants