P3567R2 flat_meow fixes
#8524
Open
P3567R2 flat_meow fixes
#8524
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
There's no need for an issue, the intended design is clear: they should all be constexpr. Please just add constexpr keywords as a fixup commit. |
Member
Yes, please. |
These functions are not marked constexpr in P3567R2, but the intent of the (already merged) P3372R3 is to mark all member functions constexpr.
Member
Author
|
Alright, I've made them all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8463
No NB comment.
Also fixes cplusplus/papers#2211
PROBLEM: cplusplus/papers#2029 added
constexprto the members offlat_meow, but what we're merging doesn't have anyconstexpron it. LWG issue? @jwakely