Skip to content

fix(cozystack): exclude loop devices from LVM global_filter #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Aleksei Sviridkin (lexfrei) merged 2 commits into from
Jun 3, 2026
Merged

fix(cozystack): exclude loop devices from LVM global_filter #215

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
197fa71
fix(cozystack): exclude loop devices from LVM global_filter
kvaps Jun 3, 2026
fbc207f
test(engine): pin loop entry in lvm.conf global_filter contract
lexfrei Jun 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/cozystack/templates/_helpers.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ machine:
archive = 0
}
devices {
global_filter = [ "r|^/dev/drbd.*|", "r|^/dev/dm-.*|", "r|^/dev/zd.*|" ]
global_filter = [ "r|^/dev/drbd.*|", "r|^/dev/dm-.*|", "r|^/dev/zd.*|", "r|^/dev/loop.*|" ]
}
{{- with .Values.extraMachineFiles }}
{{- toYaml . | nindent 2 }}
Expand Down
7 changes: 5 additions & 2 deletions pkg/engine/contract_machine_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -630,8 +630,10 @@ func TestContract_Machine_CertSANs_LoopbackUnconditional_Cozystack(t *testing.T)
// plugin paths. Required for SR-IOV / GPU device plugins to
// surface inside privileged containers.
// 2. /etc/lvm/lvm.conf — disables LVM backup/archive and sets a
// global_filter that excludes drbd, dm-, zd- devices. Required so
// LVM does not race the storage stack at boot.
// global_filter that excludes drbd, dm-, zd-, loop devices.
// Required so LVM does not race the storage stack at boot, and
// so the host never activates a volume group living inside a
// loop-mounted image.
//
// Both files use op: create / op: overwrite respectively. A regression
// removing either silently breaks GPU/SRIOV or LVM ordering.
Expand All @@ -651,6 +653,7 @@ func TestContract_Machine_Files_Cozystack(t *testing.T) {
assertContains(t, out, `r|^/dev/drbd.*|`)
assertContains(t, out, `r|^/dev/dm-.*|`)
assertContains(t, out, `r|^/dev/zd.*|`)
assertContains(t, out, `r|^/dev/loop.*|`)
})
}
}
Expand Down
Loading