Support specifying greyscale weights and use integer approximation if desired #116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danimoh
force-pushed
the
daniel/support-color-correction
branch
3 times, most recently
from
f99e01d to
90accc7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Cosmo.
I don't know whether you're interested in a change like this, but as I needed it myself, I thought I might as well open up a pull request.
It's not documented in the README yet, but if you're interested, I can add it.
The idea is to provide an option to adapt the weights used in grayscale computation to adapt to differently gamma corrected images or to optimize contrast for colored qr codes, if the used color is known upfront.
Also if desired, a faster integer approximation can be used.