-
Notifications
You must be signed in to change notification settings - Fork 697
[feat][backend]Support workflow automation tasks #267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…/workflow_auto_task
…/workflow_auto_task
…/workflow_auto_task
# Conflicts: # backend/modules/observability/domain/task/service/taskexe/tracehub/scheduled_task.go
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (64.70%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. @@ Coverage Diff @@
## main #267 +/- ##
==========================================
- Coverage 68.42% 68.42% -0.01%
==========================================
Files 585 585
Lines 54127 54154 +27
==========================================
+ Hits 37039 37056 +17
- Misses 14254 14259 +5
- Partials 2834 2839 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
CozeLoop
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary: Found a blocking type mismatch for TaskSource in DTO/DO convertors (compile-time error), plus an API design suggestion around ListTasks hard‑coded task_source filter. Please address the MUST FIX before merging.
MUST FIX:
- Convert TaskSource between *string and *task.TaskSource explicitly in application/convertor/task/task.go.
SUGGESTION:
- Only append default task_source filter when the client doesn’t specify it to keep API composability.
backend/modules/observability/application/convertor/task/task.go
Outdated
Show resolved
Hide resolved
backend/modules/observability/application/convertor/task/task.go
Outdated
Show resolved
Hide resolved
backend/modules/observability/domain/task/service/task_service.go
Outdated
Show resolved
Hide resolved
release/deployment/docker-compose/bootstrap/mysql-init/init-sql/task.sql
Show resolved
Hide resolved
release/deployment/helm-chart/charts/app/bootstrap/init/mysql/init-sql/task.sql
Show resolved
Hide resolved
# Conflicts: # backend/modules/observability/application/task.go # backend/modules/observability/domain/task/service/task_service.go # backend/modules/observability/domain/task/service/task_service_test.go
What type of PR is this?
Check the PR title.
(Optional) Translate the PR title into Chinese.
(Optional) More detailed description for this PR(en: English/zh: Chinese).
en:
zh(optional):
(Optional) Which issue(s) this PR fixes: