Skip to content

Conversation

@zero3233-bd
Copy link
Collaborator

What type of PR is this?

Check the PR title.

  • This PR title match the format: [<type>][<scope>]: <description>. For example: [fix][backend] flaky fix
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Add documentation if the current PR requires user awareness at the usage level.
  • This PR is written in English. PRs not in English will not be reviewed.

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

@codecov
Copy link

codecov bot commented Nov 18, 2025

Codecov Report

❌ Patch coverage is 64.70588% with 12 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
backend/modules/observability/application/task.go 52.94% 4 Missing and 4 partials ⚠️
...s/observability/application/convertor/task/task.go 33.33% 2 Missing and 2 partials ⚠️

❌ Your patch check has failed because the patch coverage (64.70%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #267      +/-   ##
==========================================
- Coverage   68.42%   68.42%   -0.01%     
==========================================
  Files         585      585              
  Lines       54127    54154      +27     
==========================================
+ Hits        37039    37056      +17     
- Misses      14254    14259       +5     
- Partials     2834     2839       +5     
Flag Coverage Δ
unittests 68.42% <64.70%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...modules/observability/domain/task/entity/filter.go 0.00% <ø> (ø)
...d/modules/observability/domain/task/entity/task.go 47.00% <ø> (ø)
.../observability/domain/task/service/task_service.go 79.10% <100.00%> (+0.97%) ⬆️
...s/observability/application/convertor/task/task.go 73.79% <33.33%> (-0.70%) ⬇️
backend/modules/observability/application/task.go 70.31% <52.94%> (-1.04%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69e4503...319a6ad. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@CozeLoop CozeLoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary: Found a blocking type mismatch for TaskSource in DTO/DO convertors (compile-time error), plus an API design suggestion around ListTasks hard‑coded task_source filter. Please address the MUST FIX before merging.

MUST FIX:

  • Convert TaskSource between *string and *task.TaskSource explicitly in application/convertor/task/task.go.

SUGGESTION:

  • Only append default task_source filter when the client doesn’t specify it to keep API composability.

# Conflicts:
#	backend/modules/observability/application/task.go
#	backend/modules/observability/domain/task/service/task_service.go
#	backend/modules/observability/domain/task/service/task_service_test.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants