Skip to content

stargate, faucet: add missing .name field to Error subclasses #1861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

stargate, faucet: add missing .name field to Error subclasses #1861

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/faucet/src/api/httperror.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ export class HttpError extends Error {

public constructor(status: number, text: string, expose = true) {
super(text);
this.name = "HttpError";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
this.name = "HttpError";
this.name = this.constructor.name;

this.status = status;
this.expose = expose;
}
Expand Down
2 changes: 2 additions & 0 deletions packages/stargate/src/stargateclient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ export class TimeoutError extends Error {

public constructor(message: string, txId: string) {
super(message);
this.name = "TimeoutError";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
this.name = "TimeoutError";
this.name = this.constructor.name;

this.txId = txId;
}
}
Expand Down Expand Up @@ -179,6 +180,7 @@ export class BroadcastTxError extends Error {

public constructor(code: number, codespace: string, log: string | undefined) {
super(`Broadcasting transaction failed with code ${code} (codespace: ${codespace}). Log: ${log}`);
this.name = "BroadcastTxError";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
this.name = "BroadcastTxError";
this.name = this.constructor.name;

this.code = code;
this.codespace = codespace;
this.log = log;
Expand Down
Loading