Skip to content

Package code in the dist/ directory #1854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Package code in the dist/ directory #1854

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
030e8c0
simplify jasmine config
dynst Aug 16, 2025
c319f9f
switch build/ and dist/ directory
dynst Aug 15, 2025
23e83e4
silence unbound variable warning
dynst Aug 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/amino/jasmine-testrunner.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ const defaultSpecReporterConfig = require("../../jasmine-spec-reporter.config.js
const Jasmine = require("jasmine");
const jasmine = new Jasmine();
jasmine.loadConfig({
spec_dir: "build",
spec_files: ["**/*.spec.js"],
helpers: [],
random: false,
Expand Down
2 changes: 1 addition & 1 deletion packages/amino/karma.conf.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ module.exports = function (config) {
frameworks: ["jasmine"],

// list of files / patterns to load in the browser
files: ["dist/web/tests.js"],
files: ["build/web/tests.js"],

client: {
jasmine: {
Expand Down
10 changes: 5 additions & 5 deletions packages/amino/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,11 @@
],
"license": "Apache-2.0",
"exports": {
"types": "./build/index.d.ts",
"default": "./build/index.js"
"types": "./dist/index.d.ts",
"default": "./dist/index.js"
},
"files": [
"build/",
"dist/",
"*.md",
"!*.spec.*",
"!**/testdata/"
Expand All @@ -33,8 +33,8 @@
"test-chrome": "yarn pack-web && karma start --single-run --browsers ChromeHeadless karma.conf.cjs",
"test": "yarn build-or-skip && yarn test-node",
"coverage": "nyc --reporter=text --reporter=lcov yarn test --quiet",
"build": "rm -rf ./build && tsc",
"build-or-skip": "[ -n \"$SKIP_BUILD\" ] || yarn build",
"build": "rm -rf ./dist/ && tsc",
"build-or-skip": "[ -n \"${SKIP_BUILD:-}\" ] || yarn build",
"pack-web": "yarn build-or-skip && webpack --mode development --config webpack.web.config.cjs"
},
"dependencies": {
Expand Down
2 changes: 1 addition & 1 deletion packages/amino/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"extends": "../../tsconfig.json",
"compilerOptions": {
"baseUrl": ".",
"outDir": "build",
"outDir": "dist",
"rootDir": "src"
},
"include": [
Expand Down
4 changes: 2 additions & 2 deletions packages/amino/webpack.web.config.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,13 @@ const path = require("path");
const webpack = require("webpack");

const target = "web";
const distdir = path.join(__dirname, "dist", "web");
const distdir = path.join(__dirname, "build", "web");

module.exports = [
{
// bundle used for Karma tests
target: target,
entry: globSync("./build/**/*.spec.js", { dotRelative: true }).sort(),
entry: globSync("./dist/**/*.spec.js", { dotRelative: true }).sort(),
output: {
asyncChunks: false,
path: distdir,
Expand Down
1 change: 0 additions & 1 deletion packages/cosmwasm-stargate/jasmine-testrunner.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ const defaultSpecReporterConfig = require("../../jasmine-spec-reporter.config.js
const Jasmine = require("jasmine");
const jasmine = new Jasmine();
jasmine.loadConfig({
spec_dir: "build",
spec_files: ["**/*.spec.js"],
helpers: [],
random: false,
Expand Down
2 changes: 1 addition & 1 deletion packages/cosmwasm-stargate/karma.conf.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ module.exports = function (config) {
frameworks: ["jasmine"],

// list of files / patterns to load in the browser
files: ["dist/web/tests.js"],
files: ["build/web/tests.js"],

client: {
jasmine: {
Expand Down
10 changes: 5 additions & 5 deletions packages/cosmwasm-stargate/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,11 @@
],
"license": "Apache-2.0",
"exports": {
"types": "./build/index.d.ts",
"default": "./build/index.js"
"types": "./dist/index.d.ts",
"default": "./dist/index.js"
},
"files": [
"build/",
"dist/",
"*.md",
"!*.spec.*",
"!**/testdata/"
Expand All @@ -28,8 +28,8 @@
"docs": "typedoc",
"format": "prettier --write --log-level warn \"./src/**/*.ts\"",
"format-text": "prettier --write \"./*.md\"",
"build": "rm -rf ./build && tsc",
"build-or-skip": "[ -n \"$SKIP_BUILD\" ] || yarn build",
"build": "rm -rf ./dist/ && tsc",
"build-or-skip": "[ -n \"${SKIP_BUILD:-}\" ] || yarn build",
"test-node": "yarn node jasmine-testrunner.cjs",
"test-firefox": "yarn pack-web && karma start --single-run --browsers Firefox karma.conf.cjs",
"test-chrome": "yarn pack-web && karma start --single-run --browsers ChromeHeadless karma.conf.cjs",
Expand Down
2 changes: 1 addition & 1 deletion packages/cosmwasm-stargate/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"extends": "../../tsconfig.json",
"compilerOptions": {
"baseUrl": ".",
"outDir": "build",
"outDir": "dist",
"experimentalDecorators": true,
"rootDir": "src"
},
Expand Down
4 changes: 2 additions & 2 deletions packages/cosmwasm-stargate/webpack.web.config.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,13 @@ const path = require("path");
const webpack = require("webpack");

const target = "web";
const distdir = path.join(__dirname, "dist", "web");
const distdir = path.join(__dirname, "build", "web");

module.exports = [
{
// bundle used for Karma tests
target: target,
entry: globSync("./build/**/*.spec.js", { dotRelative: true }).sort(),
entry: globSync("./dist/**/*.spec.js", { dotRelative: true }).sort(),
output: {
asyncChunks: false,
path: distdir,
Expand Down
1 change: 0 additions & 1 deletion packages/crypto/jasmine-testrunner.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ const defaultSpecReporterConfig = require("../../jasmine-spec-reporter.config.js
const Jasmine = require("jasmine");
const jasmine = new Jasmine();
jasmine.loadConfig({
spec_dir: "build",
spec_files: ["**/*.spec.js"],
helpers: [],
random: false,
Expand Down
2 changes: 1 addition & 1 deletion packages/crypto/karma.conf.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ module.exports = function (config) {
frameworks: ["jasmine"],

// list of files / patterns to load in the browser
files: ["dist/web/tests.js"],
files: ["build/web/tests.js"],

client: {
jasmine: {
Expand Down
10 changes: 5 additions & 5 deletions packages/crypto/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,11 @@
],
"license": "Apache-2.0",
"exports": {
"types": "./build/index.d.ts",
"default": "./build/index.js"
"types": "./dist/index.d.ts",
"default": "./dist/index.js"
},
"files": [
"build/",
"dist/",
"*.md",
"!*.spec.*",
"!**/testdata/"
Expand All @@ -34,8 +34,8 @@
"test-chrome": "yarn pack-web && karma start --single-run --browsers ChromeHeadless karma.conf.cjs",
"test": "yarn build-or-skip && yarn test-node",
"coverage": "nyc --reporter=text --reporter=lcov yarn test --quiet",
"build": "rm -rf ./build && tsc",
"build-or-skip": "[ -n \"$SKIP_BUILD\" ] || yarn build",
"build": "rm -rf ./dist/ && tsc",
"build-or-skip": "[ -n \"${SKIP_BUILD:-}\" ] || yarn build",
"pack-web": "yarn build-or-skip && webpack --mode development --config webpack.web.config.cjs"
},
"dependencies": {
Expand Down
2 changes: 1 addition & 1 deletion packages/crypto/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"extends": "../../tsconfig.json",
"compilerOptions": {
"baseUrl": ".",
"outDir": "build",
"outDir": "dist",
"rootDir": "src"
},
"include": [
Expand Down
4 changes: 2 additions & 2 deletions packages/crypto/webpack.web.config.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,13 @@ const path = require("path");
const webpack = require("webpack");

const target = "web";
const distdir = path.join(__dirname, "dist", "web");
const distdir = path.join(__dirname, "build", "web");

module.exports = [
{
// bundle used for Karma tests
target: target,
entry: globSync("./build/**/*.spec.js", { dotRelative: true }).sort(),
entry: globSync("./dist/**/*.spec.js", { dotRelative: true }).sort(),
output: {
asyncChunks: false,
path: distdir,
Expand Down
1 change: 0 additions & 1 deletion packages/encoding/jasmine-testrunner.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ const defaultSpecReporterConfig = require("../../jasmine-spec-reporter.config.js
const Jasmine = require("jasmine");
const jasmine = new Jasmine();
jasmine.loadConfig({
spec_dir: "build",
spec_files: ["**/*.spec.js"],
helpers: [],
random: false,
Expand Down
2 changes: 1 addition & 1 deletion packages/encoding/karma.conf.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ module.exports = function (config) {
frameworks: ["jasmine"],

// list of files / patterns to load in the browser
files: ["dist/web/tests.js"],
files: ["build/web/tests.js"],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this change btw. As this is a purely dev build artifact, we can bundle from build/ to build/web/ or something like that to free the "dist" name


client: {
jasmine: {
Expand Down
10 changes: 5 additions & 5 deletions packages/encoding/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,11 @@
],
"license": "Apache-2.0",
"exports": {
"types": "./build/index.d.ts",
"default": "./build/index.js"
"types": "./dist/index.d.ts",
"default": "./dist/index.js"
},
"files": [
"build/",
"dist/",
"*.md",
"!*.spec.*",
"!**/testdata/"
Expand All @@ -33,8 +33,8 @@
"test-chrome": "yarn pack-web && karma start --single-run --browsers ChromeHeadless karma.conf.cjs",
"test": "yarn build-or-skip && yarn test-node",
"coverage": "nyc --reporter=text --reporter=lcov yarn test --quiet",
"build": "rm -rf ./build && tsc",
"build-or-skip": "[ -n \"$SKIP_BUILD\" ] || yarn build",
"build": "rm -rf ./dist/ && tsc",
"build-or-skip": "[ -n \"${SKIP_BUILD:-}\" ] || yarn build",
"pack-web": "yarn build-or-skip && webpack --mode development --config webpack.web.config.cjs"
},
"dependencies": {
Expand Down
2 changes: 1 addition & 1 deletion packages/encoding/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"extends": "../../tsconfig.json",
"compilerOptions": {
"baseUrl": ".",
"outDir": "build",
"outDir": "dist",
"rootDir": "src"
},
"include": [
Expand Down
4 changes: 2 additions & 2 deletions packages/encoding/webpack.web.config.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,13 @@ const path = require("path");
const webpack = require("webpack");

const target = "web";
const distdir = path.join(__dirname, "dist", "web");
const distdir = path.join(__dirname, "build", "web");

module.exports = [
{
// bundle used for Karma tests
target: target,
entry: globSync("./build/**/*.spec.js", { dotRelative: true }).sort(),
entry: globSync("./dist/**/*.spec.js", { dotRelative: true }).sort(),
output: {
asyncChunks: false,
path: distdir,
Expand Down
1 change: 0 additions & 1 deletion packages/faucet-client/jasmine-testrunner.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ const defaultSpecReporterConfig = require("../../jasmine-spec-reporter.config.js
const Jasmine = require("jasmine");
const jasmine = new Jasmine();
jasmine.loadConfig({
spec_dir: "build",
spec_files: ["**/*.spec.js"],
helpers: [],
random: false,
Expand Down
2 changes: 1 addition & 1 deletion packages/faucet-client/karma.conf.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ module.exports = function (config) {
frameworks: ["jasmine"],

// list of files / patterns to load in the browser
files: ["dist/web/tests.js"],
files: ["build/web/tests.js"],

client: {
jasmine: {
Expand Down
10 changes: 5 additions & 5 deletions packages/faucet-client/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,11 @@
],
"license": "Apache-2.0",
"exports": {
"types": "./build/index.d.ts",
"default": "./build/index.js"
"types": "./dist/index.d.ts",
"default": "./dist/index.js"
},
"files": [
"build/",
"dist/",
"*.md",
"!*.spec.*",
"!**/testdata/"
Expand All @@ -33,8 +33,8 @@
"test-chrome": "yarn pack-web && karma start --single-run --browsers ChromeHeadless karma.conf.cjs",
"test": "yarn build-or-skip && yarn test-node",
"coverage": "nyc --reporter=text --reporter=lcov yarn test --quiet",
"build": "rm -rf ./build && tsc",
"build-or-skip": "[ -n \"$SKIP_BUILD\" ] || yarn build",
"build": "rm -rf ./dist/ && tsc",
"build-or-skip": "[ -n \"${SKIP_BUILD:-}\" ] || yarn build",
"pack-web": "yarn build-or-skip && webpack --mode development --config webpack.web.config.cjs"
},
"devDependencies": {
Expand Down
2 changes: 1 addition & 1 deletion packages/faucet-client/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"extends": "../../tsconfig.json",
"compilerOptions": {
"baseUrl": ".",
"outDir": "build",
"outDir": "dist",
"rootDir": "src"
},
"include": [
Expand Down
4 changes: 2 additions & 2 deletions packages/faucet-client/webpack.web.config.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,13 @@ const path = require("path");
const webpack = require("webpack");

const target = "web";
const distdir = path.join(__dirname, "dist", "web");
const distdir = path.join(__dirname, "build", "web");

module.exports = [
{
// bundle used for Karma tests
target: target,
entry: globSync("./build/**/*.spec.js", { dotRelative: true }).sort(),
entry: globSync("./dist/**/*.spec.js", { dotRelative: true }).sort(),
output: {
asyncChunks: false,
path: distdir,
Expand Down
2 changes: 1 addition & 1 deletion packages/faucet/bin/cosmos-faucet
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@
const path = require("path");

// attempt to call in main file....
const faucet = require(path.join(__dirname, "..", "build", "cli.js"));
const faucet = require(path.join(__dirname, "..", "dist", "cli.js"));
faucet.main(process.argv.slice(2));
2 changes: 1 addition & 1 deletion packages/faucet/bin/cosmos-faucet-dist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@
const path = require("path");

// attempt to call in main file....
const faucet = require(path.join(__dirname, "..", "dist", "node", "cli.js"));
const faucet = require(path.join(__dirname, "..", "build", "node", "cli.js"));
faucet.main(process.argv.slice(2));
1 change: 0 additions & 1 deletion packages/faucet/jasmine-testrunner.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ const defaultSpecReporterConfig = require("../../jasmine-spec-reporter.config.js
const Jasmine = require("jasmine");
const jasmine = new Jasmine();
jasmine.loadConfig({
spec_dir: "build",
spec_files: ["**/*.spec.js"],
helpers: [],
random: false,
Expand Down
6 changes: 3 additions & 3 deletions packages/faucet/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
},
"files": [
"bin/",
"build/",
"dist/",
"*.md",
"!*.spec.*",
"!**/testdata/"
Expand All @@ -29,8 +29,8 @@
"dev-start": "yarn start-dev",
"format": "prettier --write --log-level warn \"./src/**/*.ts\"",
"format-text": "prettier --write \"./*.md\"",
"build": "rm -rf ./build && tsc",
"build-or-skip": "[ -n \"$SKIP_BUILD\" ] || yarn build",
"build": "rm -rf ./dist/ && tsc",
"build-or-skip": "[ -n \"${SKIP_BUILD:-}\" ] || yarn build",
"test-node": "yarn node jasmine-testrunner.cjs",
"test": "yarn build-or-skip && yarn test-node",
"coverage": "nyc --reporter=text --reporter=lcov yarn test --quiet",
Expand Down
2 changes: 1 addition & 1 deletion packages/faucet/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"extends": "../../tsconfig.json",
"compilerOptions": {
"baseUrl": ".",
"outDir": "build",
"outDir": "dist",
"rootDir": "src"
},
"include": [
Expand Down
Loading
Loading