Photomeson interactions - fixes and automated tests by pwit07 · Pull Request #191 · cosimoNigro/agnpy

pwit07 · 2026-02-03T11:08:13Z

Improved Photomeson_interactions.ipynb notebook (reproduced Figs. 2–7 and 14–17 from from K&A 2008)
Fixed PhotoMesonProduction class in photo_meson.py
Added automated tests using reference values from K&A 2008

review-notebook-app · 2026-02-03T11:08:19Z

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

jsitarek · 2026-02-09T14:59:05Z

agnpy/photo_meson/tests/test_kernels.py

+                          comments="#", 
+                          usecols=(0, 1), 
+                          unpack="True",
+                          converters={0: lambda x: float(x.replace(',', '.')),


better to use dot as decimal separator in files directly

jsitarek · 2026-02-09T15:01:53Z

agnpy/photo_meson/tests/test_kernels.py

@@ -1,8 +1,25 @@
 # test the kernels
-import numpy as np
+# import numpy as np


delete if it is not used

jsitarek · 2026-02-09T15:03:24Z

agnpy/photo_meson/tests/test_kernels.py

+
+# to be used only for the the validation
+from astropy.modeling.models import BlackBody
+import matplotlib.pyplot as plt


probably not needed, no plots should be generated by test file

jsitarek · 2026-02-09T15:04:12Z

agnpy/photo_meson/tests/test_kernels.py

+        # Blob with proton population
+        E_star = 3e20 * u.Unit("eV")
+        gamma_star = (E_star / mpc2).to_value("")
+        # p_p, gamma_c, gamma_min, gamma_max = 2, 1e3*gamma_star, (1.0*u.Unit("GeV")/mpc2).to_value(""), 1e6*gamma_star


jsitarek · 2026-02-09T15:09:43Z

agnpy/photo_meson/kernels.py

        #func = CubicSpline(eta_eta0, s)
-        func = lambda x: np.interp(x, eta_eta0, s)
+        # func = lambda x: np.interp(x, eta_eta0, s)
+        func = lambda x: log_interp(x, eta_eta0, s)


keep only the log interpolation

jsitarek · 2026-02-09T15:12:09Z

agnpy/photo_meson/photo_meson.py

+    "muon_antineutrino",
+]
+
+eta_0 = 0.313


move to evaluate_spectrum

jsitarek · 2026-02-09T15:20:11Z

agnpy/photo_meson/photo_meson.py

        # Integral on eta to be done from eta_0 to infinity
        eta = np.logspace(
            log10(eta_0),
            log10(eta_0) + 5,


define e.g. eta_0_range in parameters of the function with a default value of 5

jsitarek · 2026-02-09T15:22:29Z

agnpy/targets/targets.py

        self.name = "Cosmic Microwave Background Radiation"
        a = 7.5657 * 1e-15 * u.Unit("erg cm-3 K-4")  # radiation constant
        T = 2.72548 * u.K
+        self.bb = BlackBody(T)


review-notebook-app · 2026-02-09T15:58:18Z

View / edit / reply to this conversation on ReviewNB

jsitarek commented on 2026-02-09T15:58:17Z
----------------------------------------------------------------

Line #43.        # s_val_log = np.interp(eta_val, eta_eta0, s)

remove the unnecessary commented out lines

review-notebook-app · 2026-02-09T15:58:19Z

View / edit / reply to this conversation on ReviewNB

jsitarek commented on 2026-02-09T15:58:18Z
----------------------------------------------------------------

Line #55.        # ax[0,i].set_ylim(2e-2,2e0)

removed not needed commented out code

review-notebook-app · 2026-02-09T15:58:19Z

View / edit / reply to this conversation on ReviewNB

jsitarek commented on 2026-02-09T15:58:19Z
----------------------------------------------------------------

Line #59.        ax[0,i].set_xscale('log')

make a simple loop

review-notebook-app · 2026-02-09T15:58:20Z

View / edit / reply to this conversation on ReviewNB

jsitarek commented on 2026-02-09T15:58:20Z
----------------------------------------------------------------

Line #37.                interp_file, delimiter=";", dtype="float", comments="#", usecols=(0, 1), unpack="True",converters={0: lambda x: float(x.replace(',', '.')),

change , to . already in the input files

review-notebook-app · 2026-02-09T15:58:21Z

View / edit / reply to this conversation on ReviewNB

jsitarek commented on 2026-02-09T15:58:20Z
----------------------------------------------------------------

Line #63.        ax[0].text(0.2, 0.7, r"$\eta$ = 1.5 $\eta_{0}$", fontsize=12, horizontalalignment='center', verticalalignment='center', transform=ax[0].transAxes)

use param_tab value (also some things can go into a for loop

review-notebook-app · 2026-02-09T15:58:22Z

View / edit / reply to this conversation on ReviewNB

jsitarek commented on 2026-02-09T15:58:21Z
----------------------------------------------------------------

Line #69.    xphi_plot("2")

also do in a loop

review-notebook-app · 2026-02-09T15:58:22Z

View / edit / reply to this conversation on ReviewNB

jsitarek commented on 2026-02-09T15:58:22Z
----------------------------------------------------------------

Line #4.    def dNdx(x, E_p, particle):

try to use evaluate_spectrum instead of making a dedicated function

review-notebook-app · 2026-02-09T15:58:23Z

View / edit / reply to this conversation on ReviewNB

jsitarek commented on 2026-02-09T15:58:23Z
----------------------------------------------------------------

Line #121.    dNdx_plot("6")

check in which place (for what parameters) those errors appear

review-notebook-app · 2026-02-09T15:58:24Z

View / edit / reply to this conversation on ReviewNB

jsitarek commented on 2026-02-09T15:58:23Z
----------------------------------------------------------------

Line #30.            gamma_max = 1e6*gamma_star

better e.g. 30 * factor *gamma_star

grzegorzbor · 2026-02-11T20:32:24Z

agnpy/photo_meson/photo_meson.py

        blob,
        target,
-        integrator=np.trapz
+        integrator=np.trapezoid


Angpy 0.5.0 still officially supports numpy >= 1.24; trapezoid was added in numpy 2.0.
So i think we should stick to np.trapz, which works with both versions, until we drop support for numpy 1.x

pwit07 added 30 commits November 5, 2025 11:22

Clean-up

0b373ab

Reproduce figures from [KelnerAharonian2008]

2afcca4

Reproduced figures 6 and 7, corrected positron.txt

e8e83e3

Reproduced fig 13

3eec51e

Changed label

e887eea

Added fp_ExpCutoff function

146921b

Fixing

582e531

Reproduced fig 16

5bf27f0

Fig 14, 15, 16, 17

3dd713a

Added normalization

d1d27b3

Repaired Photomeson_interactions.ipynb

b636c58

Undo changes

997ccb8

Repaired Photomeson_interactions.ipynb

53bb41a

Optimization

e627265

Clean-up

3852d09

Small correction

c82964e

Comparison with plot values

5c33623

Comparison to KA2008

966c248

Comparison to KA2008 part II

7a2b822

Small correction

5109238

Small correction part II

a986a94

Changed interpolation method

8e6eba5

Interpolation check

d12cf73

Interpolation check part II

26210d7

Implemented extrapolation

a0c042b

mplemented extrapolation part II

25ed961

Clean-up

4215d56

Clean-up part II

1fea8d7

Added du_dnu function to CMB

2fffc29

Added automatic tests

dec0da4

pwit07 added 8 commits January 28, 2026 17:45

Clean-up

99fb577

Clean-up part II

d45973b

Clean-up part III

14c6925

Clean-up part IV

0173c17

Clean-up part V

1297341

Clean-up part VI

d2af830

Clean-up part VII

fb63275

Clean-up part VIII

19f30b2

jsitarek reviewed Feb 9, 2026

View reviewed changes

agnpy/photo_meson/photo_meson.py Outdated

"muon_antineutrino",

]

eta_0 = 0.313

Copy link

Collaborator

jsitarek Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move to evaluate_spectrum

jsitarek reviewed Feb 9, 2026

View reviewed changes

grzegorzbor reviewed Feb 11, 2026

View reviewed changes

pwit07 added 3 commits February 13, 2026 15:18

Clean-up part IX

e235b5a

Clean-up part X

172acc6

Clean-up part XI

2800e39

Conversation

pwit07 commented Feb 3, 2026

Uh oh!

review-notebook-app bot commented Feb 3, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

review-notebook-app bot commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

review-notebook-app bot commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

review-notebook-app bot commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

review-notebook-app bot commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

review-notebook-app bot commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

review-notebook-app bot commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

review-notebook-app bot commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

review-notebook-app bot commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

review-notebook-app bot commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

review-notebook-app bot commented Feb 9, 2026 •

edited

Loading

review-notebook-app bot commented Feb 9, 2026 •

edited

Loading

review-notebook-app bot commented Feb 9, 2026 •

edited

Loading

review-notebook-app bot commented Feb 9, 2026 •

edited

Loading

review-notebook-app bot commented Feb 9, 2026 •

edited

Loading

review-notebook-app bot commented Feb 9, 2026 •

edited

Loading

review-notebook-app bot commented Feb 9, 2026 •

edited

Loading

review-notebook-app bot commented Feb 9, 2026 •

edited

Loading

review-notebook-app bot commented Feb 9, 2026 •

edited

Loading