Upgrade to go 1.24 and test with go 1.26#515
Merged
Luap99 merged 5 commits intocoreos:mainfrom Mar 13, 2026
Merged
Conversation
kolyshkin
approved these changes
Mar 13, 2026
Collaborator
kolyshkin
left a comment
kolyshkin
left a comment
There was a problem hiding this comment.
Just a single nit, otherwise lgtm
.github/workflows/go.yml
Outdated
| - uses: golangci/golangci-lint-action@v9 | ||
| with: | ||
| version: v2.7 | ||
| version: v2.11.3 |
Collaborator
There was a problem hiding this comment.
Nit: I'd skip the patch version (merely 2.11 which means "latest 2.11.x.")
Collaborator
Author
There was a problem hiding this comment.
Sure I guess with how rarely we will update it and how often they publish new minor versions I guess it makes no practical difference but yeah no reason to force a specific patch version here. Fixed.
The older version does not support go 1.26 but the workflow installs go 1.26 as it ask for the stable go version. Therefore CI fails currently. Fix this by updating golangci-lint to the latest version which does support go 1.26. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
It is stable now so we should test everything works Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Switches one user to strings.Builder instead of appending strings. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Take advantage of go 1.24. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see commits