[16.0][mig] customer_wallet_(account-portal-pos)

[legalsylvain]

Description

Fixes

• remove useless dependency to website module.
• set customer_wallet_pos autoinstallable, otherwise, wallet amount is wrong if point_of_sale is installed.
• improve computation performance.

refactoring

• rename modules. So, the modules are next to each other in the repository. Also the main module doesn't require "account" suffix.
  • account_customer_wallet -> customer_wallet
  • portal_customer_wallet -> customer_wallet_portal
  • pos_customer_wallet -> customer_wallet_pos
• move transient model in wizard folder
• renaming js file, to follow odoo convention
• minimum_wallet_amount is now stored

New features

• account.payment.register : add a banner on payment form, to mention that it is possible to use Wallet Journal.
• res.partner : new tree view to see all customer wallet amounts.
• res.partner : add the wallet amount in the top of partner form view
• res.partner : have the possibility to see the detail of all the moves that justify the current wallet amount. + same in portal.
• Add possibility to redistribute wallet amount from a partner to another. (or many other.)

Doc

• full update of documentation. Adding screenshot.

Checklist before approval

• Tests are present (or not needed).
• Credits/copyright have been changed correctly.
• Change log snippet is present.
• (If a new module) Moving this to OCA has been considered.

[github-grap-bot]

Hi @carmenbianca,
some modules you are maintaining are being modified, check this out!

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 90.46610% with 45 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.54%. Comparing base (110387a) to head (37b4cc9).
⚠️ Report is 469 commits behind head on 16.0.

Files with missing lines	Patch %	Lines
customer_wallet_portal/controllers/main.py	41.66%	14 Missing ⚠️
customer_wallet_pos/models/pos_session.py	78.94%	10 Missing and 2 partials ⚠️
...let/wizards/customer_wallet_redistribute_wizard.py	82.22%	5 Missing and 3 partials ⚠️
customer_wallet/models/res_partner.py	91.42%	5 Missing and 1 partial ⚠️
customer_wallet/models/account_payment.py	33.33%	1 Missing and 1 partial ⚠️
...er_wallet/wizards/customer_wallet_detail_wizard.py	91.66%	1 Missing and 1 partial ⚠️
customer_wallet_pos/tests/common.py	97.61%	0 Missing and 1 partial ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@             Coverage Diff             @@
##             16.0     #397       +/-   ##
===========================================
- Coverage   94.17%   81.54%   -12.64%     
===========================================
  Files          34      205      +171     
  Lines         584     2649     +2065     
  Branches       56      261      +205     
===========================================
+ Hits          550     2160     +1610     
- Misses         27      446      +419     
- Partials        7       43       +36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[legalsylvain]

Ready for review.

Full description of account_wallet module :

https://github.com/grap/coopiteasy-addons/tree/16.0-mig-pos_customer_wallet-SLG-2026/customer_wallet#account-customer-wallet

Full description of account_wallet_pos module :

https://github.com/grap/coopiteasy-addons/tree/16.0-mig-pos_customer_wallet-SLG-2026/customer_wallet_pos#point-of-sale-customer-wallet

Full description of account_wallet_portal module :

https://github.com/grap/coopiteasy-addons/tree/16.0-mig-pos_customer_wallet-SLG-2026/customer_wallet_portal#portal-customer-wallet

[huguesdk]

as requested, here is my in-progress review. i will continue reviewing it afterwards.

but first of all: great work, thanks! i tested it functionally, and it works like a charm.

[huguesdk]

please don’t modify this file directly: it will be updated automatically on merge.

[legalsylvain]

I can't ! It's done automatically by pre-commit execution AFAIK.

[huguesdk]

pre-commit generates the modules’ README.rst and index.html files, but this one is generated by oca-gen-addons-table. i think the changes here are a result of search and replace, and they might cause merge conflicts.

[huguesdk]

category names have another structure now.

Suggested change

	"category": "Accounting & Finance",
	"category": "Accounting/Accounting",

[huguesdk]

this is indeed a TransientModel, but usually, it is still put in the views directory (and its model in models).

[huguesdk]

creating a demo account (and journals) directly like this in xml doesn’t work if a new database is initialized with this module directly: at the end of the init, the account and journals are deleted when the chart of account is created in the post_init_hook of the account module. the cooperator module works around this by initializing the data in another way (see this function that is called from several places (data.xml and account.chart.template._load()) (the demo data is also initialized explicitly from this xml file to support the rare case where demo data is loaded afterwards).

because of this, if a database is initialized with this module directly, the tests will fail. however, the tests on the ci run anyway because the database is first initialized with all the modules this module depends on and the tests are run in a second step, when installing this module (actually, all the modules of the repository).

note that it is not that important (as it is only demo data, and it was already the case in 12) and can be added in the roadmap.

[huguesdk]

the name of the module is still “Account Customer Wallet”, while the technical name has changed. should the name be adapted also?

[huguesdk]

i tried to perform this operation from the web ui, and it doesn’t work. as soon as i click on “redistribute”, the amount field (which i set at 30) resets to 100 and the user error dialog pops up saying “The amount to be redistributed (100.0) is different from the sum of the amounts (30.0).”. it seems that the amount field gets recomputed. maybe instead of using a compute function, use an onchange on partner_id?

[huguesdk]

great addition!

[huguesdk]

these buttons are a great addition! however, they take quite some space in the list and cannot be hidden. moreover, the redistribute action is only available from this list. adding it as a form action on the partner would be great.

[huguesdk]

why this line?

[huguesdk]

this act_window is a nice addition too! the only strange thing about it is that it has a “new” button, which allows to create a partner. i think that’s confusing, as it should mean “new customer wallet” (even if that doesn’t make much sense). i think it’s better to prevent to create new records there.

[huguesdk]

again, great work, @legalsylvain! here is the rest of my remarks.

question: why were the modules renamed? the convention in odoo seems to be {application_name}_{feature_name} so the previous names made more sense i think, as customer_wallet is not an application.

also, please squash the rename commits, as there have been some wrongly renamed values corrected afterwards.

thanks a lot for this work!

[huguesdk]

great addition! the funny thing is that you can pay an invoice containing the customer wallet product with the amount that this invoice represents, resulting in a null operation, without actually having transferred any money.

[huguesdk]

as explained earlier, i think it is better to call a method on the partner to compute the details here, instead of using a computed field on the partner that will be computed over and over mostly uselessly.

[huguesdk]

typo in the filename: should be redistribute instead of reditribute (s missing)

[huguesdk]

this "or" should be removed: it is implied and it displays badly (vertical alignment is bad).

[huguesdk]

should probably use an onchange (and maybe a default also?) instead of compute, as the amount is reset when clicking the “redistribute” button.

[huguesdk]

this seems hacky (hardcoding a delta value like this). isn’t there a cleaner way?

[huguesdk]

Suggested change

	for (var i = 0; i < this.payment_methods_from_config.length; i++) {
	if (this.payment_methods_from_config[i].is_customer_wallet_method) {
	return this.payment_methods_from_config[i];
	}
	}
	return null;
	return this.payment_methods_from_config.find((c) => c.is_customer_wallet_method) || null;

[huguesdk]

Suggested change

	var wallet_products = [];
	for (const value of Object.values(this.env.pos.db.product_by_id)) {
	if (value.is_customer_wallet_product) {
	wallet_products.push(value);
	}
	}
	return wallet_products;
	return Object.values(this.env.pos.db.product_by_id).filter((p) => p.is_customer_wallet_product);

[huguesdk]

Suggested change

	var order = this.currentOrder;
	var method = this.find_customer_wallet_payment_method();
	var wallet_amount = 0;
	var lines_qty = 0;
	order.paymentlines.forEach((item) => {
	if (item.payment_method === method) {
	wallet_amount += item.amount;
	lines_qty += 1;
	}
	});
	return [wallet_amount, lines_qty];
	const method = this.find_customer_wallet_payment_method();
	const lines = this.currentOrder.paymentlines.filter((line) => line.payment_method === method);
	const wallet_amount = lines.reduce((sum, line) => sum + line.amount, 0);
	return [wallet_amount, lines.length];

[huguesdk]

Suggested change

	var order = this.currentOrder;
	var wallet_product_ids = [];
	var wallet_products = this.find_customer_wallet_products();
	wallet_products.forEach(function (product) {
	wallet_product_ids.push(product.id);
	});
	var wallet_amount = 0;
	var lines_qty = 0;
	order.orderlines.forEach((orderline) => {
	if (wallet_product_ids.includes(orderline.product.id)) {
	wallet_amount += orderline.get_price_without_tax();
	lines_qty += 1;
	}
	});
	return [wallet_amount, lines_qty];
	const wallet_products_ids = this.find_customer_wallet_products().map(p => p.id);
	const lines = this.currentOrder.orderlines.filter((line) => wallet_product_ids.includes(orderline.product.id));
	const wallet_amount = lines.reduce((sum, line) => sum + line.get_price_without_tax(), 0);
	return [wallet_amount, lines.length];