fix(codex): discover symlinked skills and reload MCP - #673
Open
fsioni wants to merge 1 commit into
Open
Conversation
fsioni
marked this pull request as ready for review
August 11, 2026 13:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
This fixes a regression introduced by #666 (
feat(skills): discover skills in nested category directories). That change added recursive category discovery, but also explicitly rejected every symlinked directory and added a test asserting that symlinks must not be followed.Codex CLI supports skill installations such as
~/.agents/skills/feature-flow -> ~/.claude/skills/feature-flow. After #666, Jean could still receive metadata for such a skill through explicit prompt injection, but excluded it from the invocable skill registry. Physical skill directories continued to work, which made the regression specific to symlink-based installations.This PR restores Codex-compatible directory-symlink discovery without reverting the useful nested-category support from #666: only symlinks that directly resolve to a skill root are accepted, while symlinked categories are not traversed recursively.
Separately, Jean keeps
codex app-serveralive across sessions. Its MCP registry could therefore predate changes to~/.codex/config.toml, causing configured servers such as ClickUp to be absent even though a freshcodex mcp listreported them as enabled.Validation
cargo test --manifest-path jean-core/Cargo.toml— 1080 passed, 1 ignored on upstream mainrustfmt --checkfor all changed Rust filesconfig/mcpServer/reloadsucceeded andmcpServerStatus/listincluded ClickUpbun run check:allcurrently stops on the existing unrelated lint error insrc/components/chat/ChatInput.test.tsx:37(@typescript-eslint/consistent-type-imports).