Skip to content

fix(chat): recover completed runs before duplicate guard - #659

Open
fsioni wants to merge 2 commits into
coollabsio:mainfrom
fsioni:diagnostic-anomalie-affichee
Open

fix(chat): recover completed runs before duplicate guard#659
fsioni wants to merge 2 commits into
coollabsio:mainfrom
fsioni:diagnostic-anomalie-affichee

Conversation

@fsioni

@fsioni fsioni commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Summary

image
  • reconcile runs that are still marked Running when their JSONL journal already contains a final result
  • perform this recovery before rejecting a new run as a duplicate
  • clear stale review state when a completed run is recovered

Problem

If Jean was interrupted after writing the final JSONL result but before persisting the completed run metadata, the session remained marked as running. Every subsequent message was rejected with:

Session already has a Running run — refusing to create duplicate

The conversation itself was no longer active, so users could not resume it.

Testing

  • Added regression test: completed_jsonl_run_does_not_block_the_next_run
  • cargo test chat::run_log::tests:: — 21 passed
  • rustfmt --check --edition 2021 jean-core/src/chat/run_log.rs
  • Built and manually tested an AppImage against the affected real session; sending a new message succeeded without modifying or resetting the existing configuration

Copilot AI lite review requested due to automatic review settings August 7, 2026 15:03

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants