Conversation
UpsertApplicationPreview regenerated the preview domains on every call,
including from the deployment entrypoints. With a `{{random}}` preview URL
template that rewrote the stored URL of an existing preview even when the
deployment was rejected (queue full) or skipped (duplicate commit), leaving
a URL that no running container answers on.
Domains are now only generated for previews created by the action, or when
the caller explicitly asks for a regeneration - which is what the "add
preview" UI action does, matching its previous behaviour. Accepted
deployments still regenerate the domains when ApplicationDeploymentJob is
dispatched.
The action also unconditionally passed generateWithoutApplicationDomain,
so the API started handing domainless applications (Docker Image previews
in particular) a public sslip.io domain where it previously left the FQDN
unset. That flag is now opt-in and only the UI sets it.
Contributor
|
Based on the selected category, this PR's base branch was automatically changed from New features and improvements target If you believe this is incorrect, please let a maintainer know. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Issues
Category
Preview
AI Assistance
If AI was used:
Testing
curl -sS -X POST "https://$BASE_URL/api/v1/deploy" -H "Authorization: Bearer $TOKEN" -H 'Content-Type: application/json' -d '{"uuid":"$APP_ID","pull_request_id":42}'Contributor Agreement
Important