feat: allow uncontrolled volume, playbackRate, muted props #2023
+14
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jskz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
react-playerseems to always control/override some props (e.g., volume, muted, playback rate) that users might want to persist through other unrelated state changes, and we don't currently have the option to allow that behaviour.In my use case, I'd adopted use of
react-playerfor a watch party app that synchronizes the player'ssrcto values that can change from an infinite playlist of content. Users began reporting annoyance when their volume settings were being lost between videos.These settings that users frequently tweak may be better to only control if their props were actually specified.
Also see: #2005