Skip to content

Conversation

@timcoding1988
Copy link
Collaborator

update fedoral base image to 43 and related tests.
original PR

automation image pr: containers/automation_images#426

Checklist

Ensure you have completed the following checklist for your pull request to be reviewed:

  • Certify you wrote the patch or otherwise have the right to pass it on as an open-source patch by signing all
    commits. (git commit -s). (If needed, use git commit -s --amend). The author email must match
    the sign-off email address. See CONTRIBUTING.md
    for more information.
  • Referenced issues using Fixes: #00000 in commit message (if applicable)
  • Tests have been added/updated (or no tests are needed)
  • Documentation has been updated (or no documentation changes are needed)
  • All commits pass make validatepr (format/lint checks)
  • Release note entered in the section below (or None if no user-facing changes)

Does this PR introduce a user-facing change?

None

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none labels Nov 21, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 21, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: timcoding1988
Once this PR has been reviewed and has the lgtm label, please assign honny1 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@timcoding1988 timcoding1988 marked this pull request as ready for review November 21, 2025 18:09
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 21, 2025
@timcoding1988 timcoding1988 requested a review from Luap99 November 21, 2025 18:09
@jankaluza
Copy link
Member

The code change looks OK, but the failed tests on F43 look like something which need to be fixed before merging. The F42 tests pass and I also checked that the F43 test failures are specific to this PR - they do not appear on other PRs.

@jankaluza
Copy link
Member

jankaluza commented Nov 24, 2025

I think the the place where you unset NOTIFY_SOCKET is not the right one. If I do that directly in the failing test, it works as expected:

599042d

@Luap99
Copy link
Member

Luap99 commented Nov 24, 2025

I think the the place where you unset NOTIFY_SOCKET is not the right one. If I do that directly in the failing test, it works as expected:

599042d

Unsetting it in the test is not right though. If the env has a leaked NOTIFY_SOCKET it must be unset for all tests as this will affect most commands which can lead to weird failures like this.

We need to understand where (and why) it gets sets all of the sudden set and ensure it is unset before running the tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants