CGgroups v1 cleanup: Round 2 w/ container-libs vendoring #27551
Conversation
openshift-ci
bot
added
release-note-none
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lsm5 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
Depends on containers/container-libs#464 |
lsm5
force-pushed
the
cgv1-removal-vendor
branch
from
64c886a to
2b337bb
Compare
github-actions
bot
added
the
kind/api-change
lsm5
changed the title
|
|
lsm5
force-pushed
the
cgv1-removal-vendor
branch
from
2b337bb to
7da1bc6
Compare
| _, err := cgroups.New(cgroupPath, &cgroupResources) | ||
| if err != nil { | ||
| logrus.StandardLogger().Logf(logLevel, "Failed to add conmon to cgroupfs sandbox cgroup: %v", err) | ||
| } else if err := control.AddPid(cmd.Process.Pid); err != nil { |
There was a problem hiding this comment.
Is removing this correct? (I have no idea.)
There was a problem hiding this comment.
@containers/podman-maintainers wdyt? This is only in the case when cgroups manager isn't systemd which (IIRC) is safe to remove. Also, no tests failed with this removal fwiw. So if it is needed at all, do we need a test for this case too?
There was a problem hiding this comment.
no, we still support cgroupfs. We need this call to move the process to the target cgroup
There was a problem hiding this comment.
ack, got it. I'll revise. Thanks!
lsm5
force-pushed
the
cgv1-removal-vendor
branch
2 times, most recently
from
df346e1 to
c1a613b
Compare
This reverts commit cce5ec8. Note: This has already gone through a revert and re-revert cycle in commits 5273685 and 3fe402b, but that's wrong per: containers/podman#27551 (comment) . Signed-off-by: Lokesh Mandvekar <[email protected]>
lsm5
force-pushed
the
cgv1-removal-vendor
branch
from
c1a613b to
b25b3f7
Compare
Signed-off-by: Lokesh Mandvekar <[email protected]>
lsm5
force-pushed
the
cgv1-removal-vendor
branch
from
b25b3f7 to
059964e
Compare
|
[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore. |
3 participants
Checklist
Ensure you have completed the following checklist for your pull request to be reviewed:
commits. (
git commit -s). (If needed, usegit commit -s --amend). The author email must matchthe sign-off email address. See CONTRIBUTING.md
for more information.
Fixes: #00000in commit message (if applicable)make validatepr(format/lint checks)Noneif no user-facing changes)Does this PR introduce a user-facing change?