Skip to content

Conversation

@LecrisUT
Copy link
Contributor

See:

An alternative design is to add the tests in .packit.yaml. Let me know which approach would be preferred. I don't quite follow the steps you do with podman-next*.repo, maybe we could look into that as well?

(should use only one PR where we discuss and test these)

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 22, 2025

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the do-not-merge/release-note-label-needed Enforce release-note requirement, even if just None label Sep 22, 2025
@packit-as-a-service
Copy link

[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore.

3 similar comments
@packit-as-a-service
Copy link

[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore.

@packit-as-a-service
Copy link

[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore.

@packit-as-a-service
Copy link

[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore.

@lsm5 lsm5 added No New Tests Allow PR to proceed without adding regression tests and removed do-not-merge/release-note-label-needed Enforce release-note requirement, even if just None labels Sep 23, 2025
@lsm5
Copy link
Member

lsm5 commented Sep 23, 2025

@LecrisUT change itself looks good, but over here it would be preferable to add a separate set of jobs in .packit.yaml and have some github IDs included in failure notifications, like what's done for cockpit revdep tests.

@containers/podman-maintainers PTAL, wdyt? This is another set of revdep tests, this time for TMT project itself.

@lsm5
Copy link
Member

lsm5 commented Sep 23, 2025

@LecrisUT change itself looks good, but over here it would be preferable to add a separate set of jobs in .packit.yaml and have some github IDs included in failure notifications, like what's done for cockpit revdep tests.

I'd say no need to include podman-next repo in the additional job if it keeps things simpler for now. We're already catching crun and container-selinux issues in those projects.

@Luap99
Copy link
Member

Luap99 commented Sep 30, 2025

This would fall under the same rules as the cockpit tests, packit is non blocking for us so we won't gate merges on this and most maintainers will not lock at these failures as they fail to often for unrelated reasons.
As such it is up to you (or @psss I guess as you added his ping to the failure message) to react on the ping and tell the author/maintainers that this PR is actually breaking something for tmt usage.

@github-actions
Copy link

A friendly reminder that this PR had no activity for 30 days.

@github-actions github-actions bot removed the stale-pr label Nov 4, 2025
@Luap99
Copy link
Member

Luap99 commented Nov 4, 2025

Can you rebase and squash the commits, it seems kinda pointless history wise to add a file just move it it in the next commit. Once done I am fine merging as long as it is clear that podman may not block on these tests

Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I defer to @lsm5 for final review and merge.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 4, 2025
Copy link
Member

@lsm5 lsm5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 4, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 4, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LecrisUT, lsm5, Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lsm5
Copy link
Member

lsm5 commented Nov 4, 2025

/cherrypick v5.7

@openshift-cherrypick-robot
Copy link
Collaborator

@lsm5: once the present PR merges, I will cherry-pick it on top of v5.7 in a new PR and assign it to you.

In response to this:

/cherrypick v5.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 14dee39 into containers:main Nov 4, 2025
39 of 40 checks passed
@openshift-cherrypick-robot
Copy link
Collaborator

@lsm5: new pull request created: #27433

In response to this:

/cherrypick v5.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. No New Tests Allow PR to proceed without adding regression tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants