-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Fix Commands in podman-for-windows Guide
#27066
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
In more recent Windows 11 versions (not sure about Windows 10), Windows now ships its own `curl.exe`, so PowerShell's "curl"-alias no longer exists. Changes made in this commit will replace the `curl` alias call with the actual `Invoke-WebRequest` function. Signed-off-by: Manuel Thalmann <[email protected]>
Changes made in this commit will fix containers#16168 The current command in the docs expect a `docker.exe` file to exist in the current working directory. As this is most likely a typo, changes made in this commit fix this issue. Signed-off-by: Manuel Thalmann <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: neurolag The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Luap99
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you drop the [skip-ci] prefix from your commit messages. Stuff like this should never skip CI as basic validation such as spell checkers, formatters, etc... still run.
And also it would need to be part of the PR description to have nay effect, cirrus ci won't take the commit title into account so it didn't work anyway,
Honny1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from the points that @Luap99 raised, LGTM.
|
A friendly reminder that this PR had no activity for 30 days. |
|
@neurolag are you going to add the requested changes or can I pick this up? |
|
Oooh so Sorry - I totally overlooked this |
|
closing in favor of #27438 |
Does this PR introduce a user-facing change?
None