[Tigron]: support multi-parameters for expect.Contains and expect.DoesNotContain
#4136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apostasie
force-pushed
the
tigron-2025-04-contains-multi
branch
from
a549d66 to
6b9a26a
Compare
|
Failure is #4046 |
|
Needs rebase |
Signed-off-by: apostasie <[email protected]>
Signed-off-by: apostasie <[email protected]>
apostasie
force-pushed
the
tigron-2025-04-contains-multi
branch
from
6b9a26a to
4e96113
Compare
Not quite sure why it needed it... 🤷♂️ Anyhow, done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On top of #4122.Broken out of #4129.
This is a small, purely quality of life PR, that allows
expect.Containsandexpect.DoesNotContainto accept more than one argument.Second commit does cleanup tests, eg: replacing
expect.All(expect.Contains("foo"), ..., expect.Contains("bar"))with the easier-on-the-eyes notation:expect.Contains("foo", "bar").