fix: Honour Explicit PostgreSQL min_conns=0 with Presence Flag

[Copilot]

Summary

Allow Harbor to distinguish unset min_conns from explicitly configured 0 without converting MinConns to a pointer type. This keeps default fallback behavior (2) for unset values while honoring explicit 0 and rejecting explicit negatives.

• Model presence tracking

  • Added MinConnsSet bool \json:"-"`tomodels.PostGreSQL` to represent configuration presence independently from numeric value.

• Pool application semantics

  • dbpool.applyPoolConfig now applies:
    • MinConnsSet == false → DefaultMinConns (2)
    • MinConnsSet == true + MinConns >= 0 → use configured value (including 0)
    • MinConnsSet == true + MinConns < 0 → return validation error
  • dbpool.New now propagates this startup/config error.

• Config ingestion paths

  • Standard Harbor config paths (pkg/config/manager.go, lib/config/systemconfig.go) now set MinConnsSet: true when materializing DB config.
  • Exporter Viper path now uses viper.IsSet("database.min_conns") so explicit HARBOR_DATABASE_MIN_CONNS=0 is not treated as unset.

if !cfg.MinConnsSet {
	poolCfg.MinConns = DefaultMinConns
} else if cfg.MinConns < 0 {
	return fmt.Errorf("dbpool: invalid min_conns %d: must be greater than or equal to 0", cfg.MinConns)
} else {
	poolCfg.MinConns = cfg.MinConns
}

Related Issues

Type of Change

• Bug fix (fix:)
• New feature (feat:)
• Breaking change (feat!: / fix!:)
• Documentation (docs:)
• Refactoring (refactor:)
• CI/CD or build changes (ci: / build:)
• Upstream Harbor cherry-pick (upstream:)
• Dependencies update (chore:)
• Tests (test:)

Release Notes

PostgreSQL min_conns now correctly honors explicit 0 (disable prewarmed connections) while preserving Harbor’s fallback default (2) when unset. Explicit negative values now fail fast with a clear configuration error.

Testing

• Unit tests added/updated
• Manual testing performed

Checklist

• PR title follows Conventional Commits format
• Commits are signed off (git commit -s)
• No new warnings introduced

[gitar-bot]

Gitar is working

_Gitar

[Copilot]

Pull request overview

Adds presence tracking so PostgreSQL min_conns=0 is honored while unset values retain the default of 2.

Changes:

• Adds and propagates MinConnsSet.
• Validates negative values and propagates errors.
• Adds unit tests for unset, zero, and negative values.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
src/common/models/database.go	Adds the presence flag.
src/lib/dbpool/pool.go	Applies presence-aware pool configuration.
src/lib/dbpool/pool_test.go	Tests pool semantics and validation.
src/pkg/config/manager.go	Marks manager-provided values as set.
src/pkg/config/manager_test.go	Tests manager presence tracking.
src/lib/config/systemconfig.go	Marks system configuration values as set.
src/cmd/exporter/main.go	Detects exporter configuration presence.
src/cmd/exporter/main_test.go	Tests exporter unset and explicit-zero paths.
src/go.mod	Reclassifies OpenAPI dependencies as indirect.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[github-actions]

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

[github-actions]

Preview images for this PR are available in 8gears.container-registry.com/8gcr-pr with tag pr-586.

• 8gears.container-registry.com/8gcr-pr/harbor-core:pr-586
• 8gears.container-registry.com/8gcr-pr/harbor-jobservice:pr-586
• 8gears.container-registry.com/8gcr-pr/harbor-registryctl:pr-586
• 8gears.container-registry.com/8gcr-pr/harbor-exporter:pr-586
• 8gears.container-registry.com/8gcr-pr/harbor-portal:pr-586
• 8gears.container-registry.com/8gcr-pr/harbor-registry:pr-586
• 8gears.container-registry.com/8gcr-pr/trivy-adapter:pr-586

Verify a preview image:

cosign verify \
  --certificate-identity-regexp="https://github.com/container-registry/harbor-next/.github/workflows/pr-ci.yml@.*" \
  --certificate-oidc-issuer="https://token.actions.githubusercontent.com" \
  8gears.container-registry.com/8gcr-pr/harbor-core:pr-586

Verify SBOM attestation:

cosign verify-attestation \
  --certificate-identity-regexp="https://github.com/container-registry/harbor-next/.github/workflows/pr-ci.yml@.*" \
  --certificate-oidc-issuer="https://token.actions.githubusercontent.com" \
  --type spdxjson \
  8gears.container-registry.com/8gcr-pr/harbor-core:pr-586