Conversation
Signed-off-by: Anuraag Agrawal <anuraaga@gmail.com>
| async def start(): | ||
| # Currently explicit env not accepted but it's safe to set it here. | ||
| os.environ["READ_MAX_BYTES"] = str(request.message_receive_limit) | ||
| async with PyvoyServer( |
There was a problem hiding this comment.
Technically switching to programmatic is a workaround for an issue that pyvoy only prints a single port even if there are several (for HTTP/3, when setting port=0, the TLS and QUIC port end up separate due to Envoy's behavior).
But I figured it cleans things up anyways, it's still a subprocess, just not subprocess of subprocess.
There was a problem hiding this comment.
is that something you'd want to fix upstream in pyvoy?
There was a problem hiding this comment.
Yup intend to, though not to revert this back, I think programmatic works well here
There was a problem hiding this comment.
yep, looks reasonable to me.
Signed-off-by: Anuraag Agrawal <anuraaga@gmail.com>
| async def start(): | ||
| # Currently explicit env not accepted but it's safe to set it here. | ||
| os.environ["READ_MAX_BYTES"] = str(request.message_receive_limit) | ||
| async with PyvoyServer( |
There was a problem hiding this comment.
is that something you'd want to fix upstream in pyvoy?
|
|
||
| async def start(): | ||
| # Currently explicit env not accepted but it's safe to set it here. | ||
| os.environ["READ_MAX_BYTES"] = str(request.message_receive_limit) |
There was a problem hiding this comment.
Is this just so we pipe through the environment that was already going to the subprocess?
There was a problem hiding this comment.
Yeah. While I thought it was a rare use case, I will add extra_env or something to PyvoyServer to simplify this one
2 participants
Nothing special connectrpc-wise for supporting HTTP/3 but figured it's worth keeping tabs on our feature set