Add exception to metadata interceptors on_end#149
Merged
anuraaga merged 2 commits intoconnectrpc:mainfrom Mar 3, 2026
Merged
Conversation
Signed-off-by: Anuraag Agrawal <anuraaga@gmail.com>
anuraaga
changed the title
stefanvanburen
approved these changes
Mar 3, 2026
test/test_interceptor.py
Outdated
| await client_async.make_hat(Size(inches=-10)) | ||
| assert ( | ||
| interceptor.result | ||
| == ["Hello MakeHat and goodbye with error Size must be non-negative"] * 2 |
Member
There was a problem hiding this comment.
need more coffee, but why are all of these * 2 again?
Collaborator
Author
There was a problem hiding this comment.
I had the same question actually when working on this. Split up the server / client interceptor
Member
There was a problem hiding this comment.
thanks, now that makes sense!
stefanvanburen
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Realized while starting OTel middleware - while metadata interceptors aren't meant to support any type of interception, a logging interceptor was definitely in mind when defining them, and that would need access to any raised exceptions.