Conversation
| === "ASGI" | ||
|
|
||
| ```python | ||
| class GoodbyeInterceptor: |
There was a problem hiding this comment.
This example is very contrived, but I couldn't come up with anything much better, at least if demonstrating response overriding. I wanted to present the basic mechanism before going to metadata interceptors, which are actually going to be 90% of interceptors.
Happy to hear any thoughts
There was a problem hiding this comment.
seems fine to me to have it start this way — I don't have a less contrived version off-hand from using interceptors in other implementations for request replacement. As you said, it's typically metadata that's changed.
Signed-off-by: Anuraag Agrawal <anuraaga@gmail.com>
Signed-off-by: Anuraag Agrawal <anuraaga@gmail.com>
953e176 to
6473835
Compare
| === "ASGI" | ||
|
|
||
| ```python | ||
| class GoodbyeInterceptor: |
There was a problem hiding this comment.
seems fine to me to have it start this way — I don't have a less contrived version off-hand from using interceptors in other implementations for request replacement. As you said, it's typically metadata that's changed.
Referred to the Go page for context but content mostly different due to the different signatures.