Fix generation and add check to CI#12
Merged
stefanvanburen merged 4 commits intomainfrom Sep 24, 2025
Merged
Conversation
This fixes `just generate` and adds a justfile target to check that generation doesn't change files in CI (we do [something similar in protovalidate-python][1] and I used the same logic). I also added comments to the justfile targets so `just --list` has a short description. [1]: https://github.com/bufbuild/protovalidate-python/blob/1f0d1837077765e4c21933202594bddb9f065b5a/Makefile#L72-L75 Signed-off-by: Stefan VanBuren <svanburen@buf.build>
Shouldn't change based on OS, similar to how we have the lint step. And add a simple name to the step. Signed-off-by: Stefan VanBuren <svanburen@buf.build>
stefanvanburen
force-pushed
the
svanburen/fix-generation
branch
from
f8fb5cd to
aab6b1f
Compare
`sed` differences :( Signed-off-by: Stefan VanBuren <svanburen@buf.build>
Signed-off-by: Stefan VanBuren <svanburen@buf.build>
stefanvanburen
force-pushed
the
svanburen/fix-generation
branch
from
84fb17f to
eb3ebfc
Compare
spenczar
approved these changes
Sep 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes
just generateand adds a justfile target to check that generation doesn't change files in CI (we do something similar in protovalidate-python and I used the same logic).I also added comments to the justfile targets so
just --listhas a short description.